Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide empty spaces where validation is enabled but nothing to show #5485

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

andydotxyz
Copy link
Member

This includes a slight change in behaviour that errors would be shown after initial input is completed.
It is helpful to avoid forms jumping around when focus changes.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 62.69% (+0.01%) from 62.676%
when pulling 0aa8f06 on andydotxyz:fix/formspacing
into 4e77e09 on fyne-io:develop.

@dweymouth
Copy link
Contributor

Does this cause "jumps" in the layout positioning when a validation error is shown then? If so, I wonder if it should be somehow themeable because some may prefer the compact layout while others prefer no layout jumps?

@andydotxyz
Copy link
Member Author

Yes if and only if an error appears with no hint. If a developer wants to prop it open they could use " " as a hint.

@dweymouth
Copy link
Contributor

Yes if and only if an error appears with no hint. If a developer wants to prop it open they could use " " as a hint.

Good point that " " can prop it open if desired

@andydotxyz
Copy link
Member Author

Does that mean we're good @dweymouth ?

@andydotxyz andydotxyz merged commit 5ebf631 into fyne-io:develop Feb 3, 2025
11 checks passed
@andydotxyz andydotxyz deleted the fix/formspacing branch February 3, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants