feat: Allow setting custom Layout paddings #4813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamantike
changed the title
Introduce a `LayoutOption` concept, and allow setting custom paddings for a Layout. The `BaseLayout` struct implements the default paddings retrieval, to reduce the amount of changes required by project maintainers to comply with the new interface methods. This change uses the Option pattern in case other customizations can be added to Layouts in the future, without changing the public API. Main motivation for this change has been Supersonic needing to copy the entire Vbox/Hbox implementation, just to add custom paddings [1]. Also related to feature request fyne-io#1031. [1] https://github.com/dweymouth/supersonic/blob/02d4082f3dae4d1d54a4384489785a5984a7a7de/ui/layouts/hboxcustompadding.go
adamantike
force-pushed
the
feat/allow-custom-paddings-for-layouts
branch
from
41ea0c7 to
748a8c5
Compare
andydotxyz
requested changes
May 5, 2024
| @@ -8,4 +8,10 @@ type Layout interface { | |||
| // MinSize calculates the smallest size that will fit the listed | |||
| // CanvasObjects using this Layout algorithm. | |||
| MinSize(objects []CanvasObject) Size | |||
| // GetPaddings returns the top, bottom, left and right paddings used | |||
| // by this layout. | |||
| GetPaddings() (float32, float32, float32, float32) | |||
There was a problem hiding this comment.
Just FYI such an addition to a published interface is a breaking change.
Anyhow this topic has been discussed a lot and you can see replacement PRs coming in that take a less-sweeping change that can be adopted more easily.
Hopefully this resolves the use-case we missed?
|
This is indeed solved by the linked PRs, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduce a
LayoutOptionconcept, and allow setting custom paddings for a Layout. TheBaseLayoutstruct implements the default paddings retrieval, to reduce the amount of changes required by project maintainers to comply with the new interface methods.This change uses the Option pattern in case other customizations can be added to Layouts in the future, without changing the public API.
Main motivation for this change has been Supersonic needing to copy the entire Vbox/Hbox implementation, just to add custom paddings [1]. Also related to feature request #1031.
[1] https://github.com/dweymouth/supersonic/blob/02d4082f3dae4d1d54a4384489785a5984a7a7de/ui/layouts/hboxcustompadding.go
Checklist:
Where applicable: