Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss the iOS soft keyboard if 'Done' button is tapped #4566

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Dismiss the iOS soft keyboard if 'Done' button is tapped #4566

merged 1 commit into from
Jan 27, 2024

Conversation

andydotxyz
Copy link
Member

Checklist:

  • Tests included. <- requires iOS hardware to run (simulator no help)
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz andydotxyz changed the title Dismiss the keyboard if 'Done' button is tapped Dismiss the iOS soft keyboard if 'Done' button is tapped Jan 26, 2024
@coveralls
Copy link

Coverage Status

coverage: 64.639% (-0.01%) from 64.653%
when pulling 9b96b3c on andydotxyz:fix/ioskeyboarddismiss
into d2e075e on fyne-io:develop.

@dweymouth dweymouth assigned dweymouth and unassigned dweymouth Jan 27, 2024
@dweymouth dweymouth self-requested a review January 27, 2024 16:06
dweymouth
dweymouth approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@dweymouth dweymouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not setup to test on iOS but this looks simple enough and I trust that you've validated it :)

@andydotxyz andydotxyz merged commit d10e5c4 into fyne-io:develop Jan 27, 2024
11 checks passed
@andydotxyz andydotxyz deleted the fix/ioskeyboarddismiss branch January 27, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweymouth dweymouth dweymouth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @dweymouth