Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement by avoiding running commands in docker #254

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

williambrode
Copy link
Contributor

I noticed that fyne-cross running on my gitlab CI was taking a very long time to clean directories that don't even exist. I found that because these cleans are run using docker - it takes a while just to spin up the container to run them.

Description:

Fixes #(issue)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.
  • Any breaking changes have a deprecation path or have been discussed.
  • Updated the vendor folder (using go mod vendor).

@andydotxyz
Copy link
Member

As noted on our chat channels, I am not sure if it was important that the old way was used - hopefully @Bluebugs, @lucor or @Jacalz can comment?

@williambrode
Copy link
Contributor Author

This is a huge performance improvement - I think it may be worth trying unless we know a reason not to do it.

@Jacalz
Copy link
Member

Jacalz commented Jul 8, 2024

I think we've all been rather busy unfortunately. I'll try to have a look first things after my vacation.

@Jacalz Jacalz self-requested a review July 8, 2024 20:09
@Bluebugs Bluebugs merged commit c007692 into fyne-io:develop Jul 13, 2024
@lucor lucor mentioned this pull request Jan 12, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants