-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable-macos-ci #243
Enable-macos-ci #243
Conversation
ad0b880
to
14c9c04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but don't we want it to run on the development branch pushes too?
@Bluebugs if you were able to rebase this on current master and add that it executes on develop as well then I think we should be in good shape. |
14c9c04
to
6329052
Compare
I don't know how it did happen, but the CI is now failing with Go 1.19 due to a dependencies that also break main/develop branch. |
Yes I am not sure how it happened either. Some combination of deprecation and linting perhaps? |
f51dc46
to
fe58fca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet thanks
Description:
Turn back on CI for MacOS and Web target.
Checklist: