Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable-macos-ci #243

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Enable-macos-ci #243

merged 2 commits into from
Jan 20, 2025

Conversation

Bluebugs
Copy link
Contributor

Description:

Turn back on CI for MacOS and Web target.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@Bluebugs Bluebugs force-pushed the enable-macos-ci branch 7 times, most recently from ad0b880 to 14c9c04 Compare April 29, 2024 00:02
@Bluebugs Bluebugs requested review from lucor and andydotxyz April 29, 2024 02:38
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but don't we want it to run on the development branch pushes too?

@andydotxyz
Copy link
Member

@Bluebugs if you were able to rebase this on current master and add that it executes on develop as well then I think we should be in good shape.

@Bluebugs
Copy link
Contributor Author

I don't know how it did happen, but the CI is now failing with Go 1.19 due to a dependencies that also break main/develop branch.

@andydotxyz
Copy link
Member

Yes I am not sure how it happened either. Some combination of deprecation and linting perhaps?
Do we need a smaller PR to resolve that first?

@Bluebugs Bluebugs requested a review from andydotxyz January 19, 2025 20:24
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet thanks

@Bluebugs Bluebugs merged commit 587799a into master Jan 20, 2025
32 checks passed
@Bluebugs Bluebugs deleted the enable-macos-ci branch January 20, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants