fix: get access token #602
Conversation
ruuushhh
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Warning Rate limit exceeded@ruuushhh has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 12 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request introduces a modification to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/fyle/helpers.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pytest
| @@ -54,7 +54,7 @@ def post_request(url: str, body: dict, refresh_token: str = None) -> Optional[di | |||
| response = requests.post( | |||
| url, | |||
| headers=api_headers, | |||
| data=body | |||
| data=json.dumps(body) | |||
There was a problem hiding this comment.
💡 Codebase verification
Remove redundant JSON serialization in workspaces/tasks.py
The change in post_request now handles JSON serialization internally, but there's a call in apps/workspaces/tasks.py that's pre-serializing the payload, which will cause double serialization. Please remove json.dumps() from:
apps/workspaces/tasks.py: Changepost_request(url, json.dumps(payload), refresh_token)topost_request(url, payload, refresh_token)
🔗 Analysis chain
LGTM! This fixes the content-type mismatch.
The change correctly serializes the request body to JSON string, which matches the 'application/json' content-type header. This should resolve any access token issues that were occurring due to improper request body formatting.
Let's verify that this change fixes the access token issues by checking the request format:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the request body format for token endpoint
# Test: Check if the token endpoint is called with proper JSON body
# Look for other instances where post_request is used without json.dumps
rg -A 5 "post_request\(" --glob "!apps/fyle/helpers.py"
Length of output: 1486
ruuushhh
had a problem deploying
to
CI Environment
GitHub Actions
Failure
ruuushhh
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #602 +/- ##
==========================================
+ Coverage 93.01% 93.19% +0.17%
==========================================
Files 62 64 +2
Lines 5957 6084 +127
==========================================
+ Hits 5541 5670 +129
+ Misses 416 414 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* fix: get access token * Fix * Fix --------- Co-authored-by: GitHub Actions <[email protected]>
* fix: get access token * Fix * Fix --------- Co-authored-by: GitHub Actions <[email protected]>
Description
fix: get access token
Clickup
https://app.clickup.com/
Summary by CodeRabbit