Support GNU-EFI 4.0

[gmbr3]

• Set GNU_EFI_3_0_COMPAT so CompareGuid runs using the old version otherwise this will break

Changed made in ncroxon/gnu-efi@a093fe0

[gmbr3]

Hmm..

fwupd-efi/efi/fwupdate.c

Line 155 in 5c72956

if (CompareGuid(&vendor_guid, &fwupdate_guid))

What's the expected return for this? True? All the other ones use == 0 or != 0

[hughsie]

Appreciated, thanks!

[hughsie]

What's the expected return for this? True? All the other ones use == 0 or != 0

We're checking if the GUID is ours

[gmbr3]

Under 3.0 logic, ==0 means match and !=0 means not match so presuming they'd be exactly the same it'd return 0 which when implicitly converted to boolean form is false? Code is working incorrectly then?

They'd be an exact match, right?

Or have I missed something?

[gmbr3]

I know why! It's a not match. So it should be !=0

It's all good 👍

[superm1]

We probably want a new fwupd-efi release out soon for stuff like this.

Is GNU-EFI 4.0 out already?

[gmbr3]

Is GNU-EFI 4.0 out already?

No but will be soon (couple of days), as there are lots of fixes and clarifications