maximize: randr: assign correct monitor to window #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When maximizing a window it's possible that a window could be between different monitors. In such cases, fvwm computes the best monitor to put the maximized window on, based on how much of that window is on a particular monitor. To do this, if a new monitor is used, this information wasn't updated in the fw structure which held the required information, so the "old" monitor ended up being used which would have yielded the incorrect EWMH information. Fixes #811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When maximizing a window it's possible that a window could be between
different monitors. In such cases, fvwm computes the best monitor to
put the maximized window on, based on how much of that window is on a
particular monitor.
To do this, if a new monitor is used, this information wasn't updated in
the fw structure which held the required information, so the "old"
monitor ended up being used which would have yielded the incorrect EWMH
information.
Fixes #811