logging: add fvwm_debug infrastructure #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For those systems which don't have asprintf natively, provide a compatibility implementation.
Don't try and include more headers than is necessary by wrapping them in an include guard.
Add log routines (modified from tmux) to be able to log what fvwm3 is doing in a more structured way than just using fprintf() calls.
Move callers of asprintf() to xasprintf().
Make FVWM3 write or stop writing to a log file, when it receives SIGUSR2.
This removes DBUG and associated configur.ac changes. This will be replaced with more fuller logging.
ThomasAdam
force-pushed
the
ta/logging
branch
4 times, most recently
from
ae537db to
95fc6be
Compare
Closed
Now that FVWM3 has logging capabilities via SIGUSR2, migrate all instances of fprintf(stderr, ...) to fvwm_debug(...); Although this might make the logfile chatty, it now means we won't miss messages otherwise printed to stderr. Some display managers (via systemd) have started to make it harder to log/find stderr. FVWM3 will create a log file in $HOME for the purposes of logging.
ThomasAdam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a framework for handling
fvwm_debug(), replacing the originalfvwm_msg()calls.Logging is now toggleable via SIGUSR2.