Add variable/parameter which indicates the state of the FVWM3 logging #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
requested changes
Oct 2, 2020
ThomasAdam
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ThomasAdam
I realized that there is no way to check if logging and debugging with SIGUSR2 is currently enabled or disabled. This may lead to the situation that something opens the log, crash and not closes it, then "opens" it again, but actually closes it.
This is my proposal for new internal varible/parameter
$[debuglog.state]with value 0 or 1 for checking this state.P. S.
In libs/log.h I already found
log_get_level()declared but unused in log.c when I wanted to declare it. So I'm probably on the trace of some forgotten idea. :-)