ta/xfixes cursor barrier #1142
Merged
ta/xfixes cursor barrier #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ThomasAdam
commented
Dec 14, 2024
ThomasAdam
commented
- cursorbarrier: forward-declare functions
- cursorbarrier: destroy barriers if MAX_BARRIERS is reached
ThomasAdam
force-pushed
the
ta/xfixes-cursor-barrier
branch
from
2b7ef70 to
9301ca3
Compare
somiaj
reviewed
Dec 14, 2024
fvwm/cursor.c
Outdated
Comment on lines
120
to
121
| #define destroy_barrier_n(a) | ||
| #define destroy_barrier_n(a) |
There was a problem hiding this comment.
It appears you are defining this function again, and I'm unsure why.
somiaj
reviewed
Dec 14, 2024
Comment on lines
+58
to
+59
| fvwm_debug(__func__, "Too many barriers. Freeing previous..."); | ||
| destroy_all_barriers(); |
There was a problem hiding this comment.
What is your reasoning here? If they reach max barriers do you just want a reset? Since you are destroying all of the barriers first, should you remove the return bellow this so the current one they are trying to create gets created?
There was a problem hiding this comment.
You might want to document this behavior in the manual page.
There was a problem hiding this comment.
It's odd either way.
No one's going to reach this limit.
Make sure we forward-declare the use of the cursor barrier function, so as to not rely on the order the functions have been declared. This will be relevant for subsequent changes.
ThomasAdam
force-pushed
the
ta/xfixes-cursor-barrier
branch
from
9301ca3 to
3bd21ae
Compare
Make sure we destroy all the defined barriers if MAX_BARRIERS is reached.
ThomasAdam
force-pushed
the
ta/xfixes-cursor-barrier
branch
from
3bd21ae to
ff5cfd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.