Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanFrames: surround monitor edges only for global mode #398

Closed
ThomasAdam opened this issue Dec 31, 2020 · 0 comments · Fixed by #399
Closed

PanFrames: surround monitor edges only for global mode #398

ThomasAdam opened this issue Dec 31, 2020 · 0 comments · Fixed by #399
Assignees
@ThomasAdam
Labels
type:bug Something's broken!
Milestone
1.0.3

Comments

@ThomasAdam
Copy link
Member

When DesktopConfiguration global is in use, only create panframes for the extremities of the global set of monitors, rather than panframes surrounding each individual monitor. Although leaving panframes in place on each monitor simplifies the code, it makes the logic harder, as these panframes persist, meaning paging is triggered on a per-monitor basis, even though that's not what the user intended.

Therefore, handle DesktopConfiguration global separately, and recreate all panframes when the DesktopConfiguration value changes.
@ThomasAdam ThomasAdam self-assigned this Dec 31, 2020
@ThomasAdam ThomasAdam added the type:bug Something's broken! label Dec 31, 2020
@ThomasAdam ThomasAdam added this to the 1.0.3 milestone Dec 31, 2020
ThomasAdam added a commit that referenced this issue Dec 31, 2020
@ThomasAdam
PanFrames: restore global panframe behaviour
27a93d5 
When initialising panframes, in global mode, only surround the
outer-edges with panframes.  This should stop odd page-switching
behaviour when previously, panframes were left per-monitor, despite a
DesktopConfiguration of 'global'.

Fixes #398
@ThomasAdam ThomasAdam mentioned this issue Dec 31, 2020
Merged
ThomasAdam added a commit that referenced this issue Dec 31, 2020
@ThomasAdam
PanFrames: restore global panframe behaviour
7c66411 
When initialising panframes, in global mode, only surround the
outer-edges with panframes.  This should stop odd page-switching
behaviour when previously, panframes were left per-monitor, despite a
DesktopConfiguration of 'global'.

Fixes #398
@ThomasAdam ThomasAdam moved this to Done in FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam added this to FVWM3 Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasAdam ThomasAdam

Labels
type:bug Something's broken!
Projects
FVWM3
Status: Done
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

PanFrames: restore global panframe behaviour fvwmorg/fvwm3
1 participant
@ThomasAdam