Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FvwmButtons Geometry - @g tag positions objects on active monitor instead of globally #269

Closed
MidFavila opened this issue Oct 23, 2020 · 7 comments · Fixed by #270
Closed
Labels
type:bug Something's broken!

Comments

@MidFavila
Copy link

I use the @g tag to position my FvwmButtons panel dynamically, along with arithmetic operations. In 2.6.9 the following string positions it to the right edge of the X screen.

*VerticalPanel: Geometry 136x$[vp.height]-0-0@g

Using a fresh install from source of FVWM2, this works fine; however, using a fresh install of 3 results in the panel and other @g-tagged elements spawning on the active X monitor, instead of the expected behavior.

To explain further, I have a three-head configuration and need my Buttons panel on the extreme right of the desktop. However, upon initializing the Buttons panel, it will appear on the monitor that currently has the cursor. This behavior only occurs when the element's Geometry is tagged with @g and can be observed in the default configuration as well, by appending @g to line 609.

For reference, regular untagged positioning of elements works fine. Let me know if any more details are needed.

Thanks.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.59. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the type:bug Something's broken! label Oct 23, 2020
@ThomasAdam
Copy link
Member

Hi @MidFavila,

Yes -- this is because in my infinite wisdom, thought it would be a good idea to assume that anything after the @ symbol was an actual output name, rater than something relative, such as g for global. Will fix.

@MidFavila
Copy link
Author

Awesome, glad to hear that.

ThomasAdam added a commit that referenced this issue Oct 23, 2020
In fvwm2, "@g", "@c", and "@p" can be used to refer to screens -- where "@g" is
global, "@c" is current, and "@p" is primary.  Support this in fvwm3 by
ensuring we don't blindly treat any characters after the "@" in a
geometry string as a literal output name.

Fixes #269
@ThomasAdam
Copy link
Member

Hi @MidFavila

Please take a look at PR #270 (branch: ta/gh-269) and let me know if it works for you. Admittedly, I've only really checked it compiles, and done very minimal testing -- so set your expectations accordingly. :P

@MidFavila
Copy link
Author

I've pulled your branch and tested it; the @g tag and friends are fine, now. Thanks for the quick PR.

I did notice some other issues relating to FvwmScript and EwmhStruts, which I can open a new set of reports for, if you'd like.

@ThomasAdam
Copy link
Member

Hi @MidFavila

OK, thank you. I'll merge that later. As for your other observations, please open as many issues as you need to.

@MidFavila
Copy link
Author

Understood. I'll close this report and open some more.

ThomasAdam added a commit that referenced this issue Oct 23, 2020
In fvwm2, "@g", "@c", and "@p" can be used to refer to screens -- where "@g" is
global, "@c" is current, and "@p" is primary.  Support this in fvwm3 by
ensuring we don't blindly treat any characters after the "@" in a
geometry string as a literal output name.

Fixes #269
mikeandmore pushed a commit to mikeandmore/fvwm3 that referenced this issue Nov 28, 2020
In fvwm2, "@g", "@c", and "@p" can be used to refer to screens -- where "@g" is
global, "@c" is current, and "@p" is primary.  Support this in fvwm3 by
ensuring we don't blindly treat any characters after the "@" in a
geometry string as a literal output name.

Fixes fvwmorg#269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something's broken!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants