Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: FvwmEvent new events in FVWM3 #26

Closed
NsCDE opened this issue Jan 28, 2020 · 2 comments · Fixed by #106
Closed

Proposal: FvwmEvent new events in FVWM3 #26

NsCDE opened this issue Jan 28, 2020 · 2 comments · Fixed by #106
Assignees
@ThomasAdam
Labels
type:enhancement Augmenting an existing feature
Milestone
1.0

Comments

@NsCDE
Copy link
Contributor

NsCDE commented Jan 28, 2020

As FvwmEvent handles new_page and new_desk window manager event, it will be nice to make RandR screen events acessible through it.

According to debug output, FVWM3 sees when monitor is added or removed, enabled or disabled, or when pointer changes active screen.

Proposal for exposing events is:

add_monitor
remove_monitor
enable_monitor
disable_monitor
change_screen

That way, user can configure custom actions and functions for this situations if wanted/needed.
@ThomasAdam ThomasAdam modified the milestone: 3.0 Jan 29, 2020
@ThomasAdam ThomasAdam added the type:enhancement Augmenting an existing feature label Jan 29, 2020
@ThomasAdam ThomasAdam added this to the post-1.0 milestone Apr 12, 2020
@mkarmona mkarmona mentioned this issue Apr 13, 2020
Closed
@ThomasAdam ThomasAdam mentioned this issue May 1, 2020
Closed
@NsCDE NsCDE mentioned this issue May 3, 2020
Closed
@ThomasAdam ThomasAdam modified the milestones: post-1.0, 1.0 May 9, 2020
@ThomasAdam ThomasAdam self-assigned this May 9, 2020
@ThomasAdam ThomasAdam mentioned this issue May 27, 2020
Closed
@ThomasAdam ThomasAdam linked a pull request May 28, 2020 that will close this issue
FvwmEvent: listen for RandR events #106
Merged
ThomasAdam added a commit that referenced this issue May 30, 2020
@ThomasAdam
FvwmEvent: listen for RandR events
cf71174 
This adds the work necessary to make FvwmEvent listen for RandR events.
Three events are supported:

* monitor_enabled -- when a monitor is "plugged" in, and active;
* monitor_disabled -- when a monitor is "unplugged" and deactivated;
* monitor_changed -- when an enabled monitor changes resolution/rotation

An "emit" flag is used to track events, separate from the on-going state
of RandR itself.

Fixes #26
@ThomasAdam
Copy link
Member

ThomasAdam commented May 30, 2020 •
edited
Loading

Hi,

So please see the ta/gh-26 branch which implements the following hooks in FvwmEvent:

  • monitor_enabled -- when a monitor is "plugged" in, and active;
  • monitor_disabled -- when a monitor is "unplugged" and deactivated;
  • monitor_changed -- when an enabled monitor changes resolution/rotation

Due to how RandR works, the finer-grained distinction between enable/add and disable/remove aren't reliable at all. But hopefully the above three should help cover most basis that people are interested in.

I've also added an example to man FvwmEvent.

ThomasAdam added a commit that referenced this issue Jun 1, 2020
@ThomasAdam
FvwmEvent: listen for RandR events
167a1cd 
This adds the work necessary to make FvwmEvent listen for RandR events.
Three events are supported:

* monitor_enabled -- when a monitor is "plugged" in, and active;
* monitor_disabled -- when a monitor is "unplugged" and deactivated;
* monitor_changed -- when an enabled monitor changes resolution/rotation

An "emit" flag is used to track events, separate from the on-going state
of RandR itself.

Fixes #26
ThomasAdam added a commit that referenced this issue Jun 3, 2020
@ThomasAdam
FvwmEvent: listen for RandR events
76e7eec 
This adds the work necessary to make FvwmEvent listen for RandR events.
Three events are supported:

* monitor_enabled -- when a monitor is "plugged" in, and active;
* monitor_disabled -- when a monitor is "unplugged" and deactivated;
* monitor_changed -- when an enabled monitor changes resolution/rotation

An "emit" flag is used to track events, separate from the on-going state
of RandR itself.

Fixes #26
ThomasAdam added a commit that referenced this issue Jun 3, 2020
@ThomasAdam
FvwmEvent: listen for RandR events
51c10b5 
This adds the work necessary to make FvwmEvent listen for RandR events.
Three events are supported:

* monitor_enabled -- when a monitor is "plugged" in, and active;
* monitor_disabled -- when a monitor is "unplugged" and deactivated;
* monitor_changed -- when an enabled monitor changes resolution/rotation

An "emit" flag is used to track events, separate from the on-going state
of RandR itself.

Fixes #26
@ThomasAdam
Copy link
Member

Hi,

This has been working well enough for me, and hence I'll merge the pull-request associated with this issue, to master.

Feel free to open a new issue if there's problems.

Thomas

ThomasAdam added a commit that referenced this issue Jun 6, 2020
@ThomasAdam
FvwmEvent: listen for RandR events
374cf0f 
This adds the work necessary to make FvwmEvent listen for RandR events.
Three events are supported:

* monitor_enabled -- when a monitor is "plugged" in, and active;
* monitor_disabled -- when a monitor is "unplugged" and deactivated;
* monitor_changed -- when an enabled monitor changes resolution/rotation

An "emit" flag is used to track events, separate from the on-going state
of RandR itself.

Fixes #26
mikeandmore pushed a commit to mikeandmore/fvwm3 that referenced this issue Nov 28, 2020
@ThomasAdam @mikeandmore
FvwmEvent: listen for RandR events
60bcdc0 
This adds the work necessary to make FvwmEvent listen for RandR events.
Three events are supported:

* monitor_enabled -- when a monitor is "plugged" in, and active;
* monitor_disabled -- when a monitor is "unplugged" and deactivated;
* monitor_changed -- when an enabled monitor changes resolution/rotation

An "emit" flag is used to track events, separate from the on-going state
of RandR itself.

Fixes fvwmorg#26
@NsCDE NsCDE mentioned this issue Dec 9, 2020
Closed
@ThomasAdam ThomasAdam moved this to Done in FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam added this to FVWM3 Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasAdam ThomasAdam

Labels
type:enhancement Augmenting an existing feature
Projects
FVWM3
Status: Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

FvwmEvent: listen for RandR events fvwmorg/fvwm3
2 participants
@ThomasAdam @NsCDE