Typo in configure script line 535, confusing libbson error message

[telerman]

In case libbson-devel is not installed (or version mismatch) the error message says:
libnson not found. Install its header files.

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.90. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[ThomasAdam]

Hi @telerman,

Thanks for spotting this. Surely you can send a pull request through to fix this? :-)

[telerman]

Hi @ThomasAdam
Thanks for reply.
I'll be glad to fix it, but I'm pretty new in such projects in Github and I'm not familiar with pull requests policies. Should I create a branch? How should the change be merged to master? Could you please instruct me or link to a documentation?
Thanks

[ThomasAdam]

Hi @telerman,

Sure, that's pretty much it. Have a read of:

https://github.com/fvwmorg/fvwm3/blob/master/dev-docs/DEVELOPERS.md#submitting-pull-requests

Let me know if there's anything you need my help with.

[telerman]

Hello Thomas! I've read the document and proceed with the instructions: Added FVWM3 repo as upstream remote (in my local working copy of fvwm3) git remote add fvwmorg https://github.com/fvwmorg/fvwm3.git && git fetch fvwmorg Created the topic branch: git switch -b ort/fix-typo-162 Rebased it against the fvwmorg/master git fetch && git rebase -i fvwmorg/master Then, when I tried to push the changes to the repo I had an issue. In the documentation you're instructing to run: git push -u origin HEAD, which is failing on remote: Permission to fvwmorg/fvwm3.git denied to telerman. As far as I understand it should be something like git push -u origin <branch name> and then the merge request should be sent to your review, or I do miss something? I'm sorry, but I have not enough experience in github and may ask too many questions. Anyway I'll be glad to take a part in FVWM and contribute. Thanks Regards, Oleg R.T.

…

On Thu, Jul 9, 2020 at 3:05 PM Thomas Adam ***@***.***> wrote: Hi @telerman <https://github.com/telerman>, Sure, that's pretty much it. Have a read of: https://github.com/fvwmorg/fvwm3/blob/master/dev-docs/DEVELOPERS.md#submitting-pull-requests Let me know if there's anything you need my help with. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#162 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE7KUG7RPVZII6SDXTKUUDTR2WXA5ANCNFSM4OVKGRDQ> .

-- -- Oleg T.

[ThomasAdam]

Hi @telerman,

So it seems that your origin remote is pointing to fvwmorg's fvwm3 repository -- origin should be pointing to your fork of fvwm3. If you look in ./.git/config in your cloned repository, you should have a section which looks similar to this:

[remote "origin"]
	url = [email protected]:fvwmorg/fvwm3.git
	fetch = +refs/heads/*:refs/remotes/origin/*

Here, the url should match the location of your fork on Github.

[telerman]

Thanks! It seems I missed the fork part in the flow. Now I forked the repo to my account and successfully pushed the change to it. Please let me know if there are any further steps. Regards Oleg R.T.

…

On Thu, Jul 9, 2020 at 3:05 PM Thomas Adam ***@***.***> wrote: Hi @telerman <https://github.com/telerman>, Sure, that's pretty much it. Have a read of: https://github.com/fvwmorg/fvwm3/blob/master/dev-docs/DEVELOPERS.md#submitting-pull-requests Let me know if there's anything you need my help with. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#162 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE7KUG7RPVZII6SDXTKUUDTR2WXA5ANCNFSM4OVKGRDQ> .

-- -- Oleg T.