Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix on scroll called after component is unmounted #101

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Fix on scroll called after component is unmounted #101

merged 4 commits into from
Apr 21, 2021

Conversation

heilmela
Copy link
Contributor

Temporary fix for #99 (comment)

@netlify
Copy link

netlify bot commented Apr 21, 2021 •
edited
Loading

Deploy preview for vue-horizontal processing.

Building with commit 09aafb2

https://app.netlify.com/sites/vue-horizontal/deploys/6080512c3746e90007f3b500

fuxingloh
fuxingloh approved these changes Apr 21, 2021
View reviewed changes
Copy link
Owner

@fuxingloh fuxingloh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into it, likely a race conditions beyond the scope of this.

The cypress tests were failing due to forked PR workflow secrets permission issues and outdated deps.

@fuxingloh fuxingloh added the fix label Apr 21, 2021
@fuxingloh fuxingloh merged commit 1fdb487 into fuxingloh:main Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuxingloh fuxingloh fuxingloh approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heilmela @fuxingloh