remove default features from chrono #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcornaz
changed the title
|
Thanks, this finally resolves that pesky CVE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
chrono, by default, transitively depends on the cratetime 0.1which has a known vulnerability: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-26235
But, as far as I can see, bollard does not need the
oldtimefeature enabled by default by chrono, and could therefore remove the transitive dependency on the vulnerable cratetime 0.1by disabling chrono's default features.