Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize addon #326

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
2013e75
Bump Ember to 3.28, upgrade packages, modernize addon
charlesfries Sep 8, 2021
9b80c6b
Lint
charlesfries Sep 8, 2021
23d2c9b
Modernize
charlesfries Sep 8, 2021
46630ad
Add eslint rules
charlesfries Sep 8, 2021
8c99da0
Cleanup
charlesfries Sep 8, 2021
7ffcc1b
Revert get removal
charlesfries Sep 8, 2021
b3f98eb
Uninstall chalk
charlesfries Sep 13, 2021
43f02e3
More native classes, update README
charlesfries Sep 14, 2021
5a72464
Revert "Uninstall chalk"
charlesfries Sep 14, 2021
46a2e17
Diff changes
charlesfries Sep 14, 2021
5e3783a
Revert automatic formatting for review (tmp)
charlesfries Sep 14, 2021
9e24b87
Revert
charlesfries Sep 14, 2021
19cb5bd
Revert
charlesfries Sep 14, 2021
89de7e1
Revert
charlesfries Sep 14, 2021
c70700b
Uninstall ember-cli-htmlbars, function name fix, more reverts
charlesfries Sep 14, 2021
a9ca71b
Revert
charlesfries Sep 14, 2021
848cb27
Cleanup
charlesfries Sep 14, 2021
c835ab7
Revert
charlesfries Sep 14, 2021
0cfc670
Restore ember-cli-htmlbars
charlesfries Sep 14, 2021
6e9dae1
Revert
charlesfries Sep 14, 2021
da9c9e7
Revert
charlesfries Sep 14, 2021
9fc9b86
Uninstall ember-one-way-controls, bump ember-copy
charlesfries Sep 14, 2021
81effaa
Bump packages, uninstall ember-cli-template-lint, disable Bower
charlesfries Sep 14, 2021
f39bf3d
Bump more packages, re-enable jQuery
charlesfries Sep 14, 2021
b318714
Merge branch 'master' of https://github.com/funkensturm/ember-local-s…
charlesfries Oct 9, 2021
000f27a
Merge branch 'funkensturm-master'
charlesfries Oct 9, 2021
6c9cccf
Update yarn.lock
charlesfries Oct 9, 2021
6e14cf2
Uninstall ember-cli-inuitcss, fix decorator issue
charlesfries Oct 9, 2021
ef46ab5
Fix tests
charlesfries Oct 9, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .bowerrc

This file was deleted.

59 changes: 36 additions & 23 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict';

module.exports = {
root: true,
parser: 'babel-eslint',
Expand All @@ -13,45 +15,56 @@ module.exports = {
],
extends: [
'eslint:recommended',
'plugin:ember/recommended'
'plugin:ember/recommended',
'plugin:prettier/recommended',
],
env: {
browser: true
},
rules: {
'ember/no-jquery': 'off',
'ember/no-new-mixins': 'off'
'ember/avoid-leaking-state-in-ember-objects': 0,
'ember/no-classic-classes': 0,
'ember/no-classic-components': 0,
'ember/no-component-lifecycle-hooks': 0,
'ember/no-jquery': 0,
'ember/no-mixins': 0,
'ember/no-new-mixins': 0,
'ember/no-string-prototype-extensions': 0,
'ember/require-tagless-components': 0,
'ember/use-ember-data-rfc-395-imports': 0,
},
overrides: [
// node files
{
files: [
'.eslintrc.js',
'.template-lintrc.js',
'ember-cli-build.js',
'index.js',
'testem.js',
'blueprints/*/index.js',
'config/**/*.js',
'tests/dummy/config/**/*.js'
],
excludedFiles: [
'addon/**',
'addon-test-support/**',
'app/**',
'tests/dummy/app/**'
'./.eslintrc.js',
'./.prettierrc.js',
'./.template-lintrc.js',
'./ember-cli-build.js',
'./index.js',
'./testem.js',
'./blueprints/*/index.js',
'./config/**/*.js',
'./tests/dummy/config/**/*.js'
],
parserOptions: {
sourceType: 'script'
sourceType: 'script',
},
env: {
browser: false,
node: true
},
plugins: ['node'],
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
// add your custom rules and overrides for node files here
})
}
]
extends: ['plugin:node/recommended'],
},
{
// Test files:
files: ['tests/**/*-test.{js,ts}'],
extends: ['plugin:qunit/recommended'],
rules: {
'ember/no-get': 0,
'qunit/no-conditional-assertions': 0,
},
},
],
};
21 changes: 21 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# unconventional js
/blueprints/*/files/
/vendor/

# compiled output
/dist/
/tmp/

# dependencies
/bower_components/
/node_modules/

# misc
/coverage/
!.*
.eslintcache

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try
6 changes: 6 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
'use strict';

module.exports = {
singleQuote: true,
printWidth: 300,
};
Loading