Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to rollback --alias. #366

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Support to rollback --alias. #366

merged 6 commits into from
Mar 29, 2024

Conversation

fujiwara
Copy link
Owner

@fujiwara fujiwara commented Feb 22, 2024

refs #360

Support rollback --alias flag to specify the alias to rollback.

Now, lambroll finds the target version to rollback by the logic as below.

  • List all versions with the lower version of the alias to rollback.
  • Pick the highest version number from these.
    • but If the version has aliases, continue to the next lower version.

But, this algorithm has a problem. The selected version may be the previous version of the other aliases.

To solve the problem, we have to detect all older versions for each deployed alias.
But I have no good idea to solve it.

@fujiwara
Copy link
Owner Author

d7ee38a adds rollback --version flag. This flag can specify the version to rollback clearly.

@fujiwara fujiwara merged commit 6191f3c into v1 Mar 29, 2024
4 checks passed
@fujiwara fujiwara deleted the feature/rollback-alias branch March 29, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant