Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Migrate from mocha to vitest #29

Merged
merged 4 commits into from
Oct 17, 2022
Merged

test: Migrate from mocha to vitest #29

merged 4 commits into from
Oct 17, 2022

Conversation

jimmycallin
Copy link
Contributor

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

Migrating from mocha to vitest for testing to reduce dependencies.

We are already using vite for building, and vitest has a similar API to jest while being much faster and requiring fewer dependencies.

Test

  • Run the tests, are they working?
  • Compare session.test.js to previous test_session.js. It should be similar with small updates due to callback -> async/await migration.

@jimmycallin jimmycallin requested a review from a team as a code owner September 26, 2022 21:57
@jimmycallin jimmycallin force-pushed the chore/change-to-vitest branch from 7d8381a to 7352d3d Compare September 26, 2022 22:00
@gismya gismya changed the title chore: Migrate from mocha to vitest test: Migrate from mocha to vitest Oct 17, 2022
gismya
gismya requested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@gismya gismya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old test_sesson.js should probably be removed.

test/session.test.js Outdated Show resolved Hide resolved
vitest.setup.js Show resolved Hide resolved
test/server.js Show resolved Hide resolved
@jimmycallin jimmycallin enabled auto-merge (squash) October 17, 2022 10:59
gismya
gismya approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@gismya gismya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Love that the tests now work in Node 18.

@jimmycallin jimmycallin merged commit 1ffb4d1 into main Oct 17, 2022
@jimmycallin jimmycallin deleted the chore/change-to-vitest branch October 17, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gismya gismya gismya approved these changes

Assignees

@lucaas lucaas

@gismya gismya

@WaylonFtrack WaylonFtrack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimmycallin @gismya @lucaas @WaylonFtrack