-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info about MultilineBracketStyle to docs, fix issue with icons #2744
Conversation
docs/content/webcomponents.js
Outdated
case 'deprecated': | ||
settingType = { | ||
icon: "bi-exclamation-triangle-fill", | ||
color: "orange-recommendation", | ||
tooltip: "This setting is deprecated and will be removed in a future version." | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to discussion if there's a better way to display this, I just figured there should be some sort of callout for deprecated settings.
I'm on the fence about this one. Your changes are fine and I can see value in having them.
My availability is limited this week, but I trust you and @dawedawe will figure it out 😉. |
Yeah, I think it could make sense to just remove the old settings with just a mention of the old settings underneath the new one just to help anyone looking to ctrl+f one of the old ones. I also wouldn't be opposed to a cli warning as well. We'd probably want to do that in a separate PR, no? |
Skimmed true this, looks good. I'm going to let @dawedawe review it properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also prefer to have a separate PR for the CLI warning.
Closes #2743, related to #2710