Trivia not restored after long identifier in SynField #2290
Conversation
There was a problem hiding this comment.
Hey @edgarfgp, thank you for this contribution.
Could you please add a changelog entry:
https://github.com/fsprojects/fantomas/blob/master/CONTRIBUTING.md#changelog
And could you please try to link the PR to the issue, see:
https://github.com/fsprojects/fantomas/blob/master/CONTRIBUTING.md#pull-request-title
| @@ -879,6 +879,25 @@ type Foo = // comment | |||
| 1 | |||
| """ | |||
|
|
|||
| [<Test>] | |||
| let ``comment after variants with modules`` () = | |||
There was a problem hiding this comment.
Could you add the issue number, please?
comment after variants with modules, 2103
There was a problem hiding this comment.
Actually, that test name isn't really good.
This has nothing to do with modules.
Maybe go for restore trivia after long identifier in SynField.
I'll update the original issue title as well.
There was a problem hiding this comment.
I have updated this PR following your suggestions :)
edgarfgp
changed the title
|
My pleasure . Let me know if there is anything else I can help ;) |
This PR adds a Regression test for #2103 as this is fixed in the upcoming v5