Pre push hook to ensure code is formatted on upload #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Feb 13, 2022
nojaf
requested changes
Feb 13, 2022
nojaf
approved these changes
Feb 13, 2022
jindraivanek
pushed a commit
to jindraivanek/fantomas
that referenced
this pull request
Mar 30, 2022
* Add a prepush hook to ensure that formatting is run * fix reporting * formatting after change, proof that the prepush hook works * add documentation and samples to prepush script * Document the need to install/configure git hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to not take this, this is a little experiment.
I added a git hook that fires before commits are pushed to a repo that invokes the
CheckFormattarget. If that target fails, the push fails.In order for this to work, by default the hook script would have to live in the
.git/hooksdirectory, but this directory isn't sharable/tracked in git. Therefore, I made a new directory to hold the hooks, and added a build script target that can be used to set up this kind of repo-local git config (since the .git/config file can't be shared for the same reason!). One other use of this target might be to set the.git-blame-ignore-revsfile configuration, for example.What do you think? I would imagine if you like this I'd need to update the README as well.