Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling 'with' clause using drop-through is malformed #465

Closed
SteveGilham opened this issue Aug 14, 2019 · 2 comments
Closed

Comments

@SteveGilham
Copy link

Description

Code like this

  let internal ImageLoadResilient (f: unit -> 'a) (tidy: unit -> 'a) =
    try
      f()
    with
    | :? BadImageFormatException
    | :? ArgumentException
    | :? IOException -> tidy()

becomes malformed

let internal ImageLoadResilient (f: unit -> 'a) (tidy: unit -> 'a) =
    try
        f()
    with :? BadImageFormatException
    | :? ArgumentException
    | :? IOException -> tidy()

Repro code

Here at v2.9.2

Also happens at the 2.9.3 preview; the 3.0.0 level preview of the tool simply faults.

@jindraivanek
Copy link
Contributor

3.0.0 tool fault was caused by unrelated issue on tool side (incompatible version of FSharp.Compiler.Service and FSharp.Core), it is fixed now. 3.0.0 repro

@nojaf
Copy link
Contributor

nojaf commented Aug 30, 2019

Should be ok now.

@nojaf nojaf closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants