Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotency problem with lazy #1609

Closed
3 tasks
Smaug123 opened this issue Apr 6, 2021 · 0 comments · Fixed by #1618
Closed
3 tasks

Idempotency problem with lazy #1609

Smaug123 opened this issue Apr 6, 2021 · 0 comments · Fixed by #1618

Comments

@Smaug123
Copy link
Contributor

Smaug123 commented Apr 6, 2021

Issue created from fantomas-online

Formatted code

module Foo =
    let bar () =

        if not
           <| RuntimeInformation.IsOSPlatform OSPlatform.Windows then
            raise
            <| PlatformNotSupportedException (
                "Blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah"
            )
        lazy
            (let foo = bar
             if ret then "" else "" |> log.LogInformation
             ret)

Reformatted code

module Foo =
    let bar () =

        if not
           <| RuntimeInformation.IsOSPlatform OSPlatform.Windows then
            raise
            <| PlatformNotSupportedException (
                "Blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah"
            )

        lazy
            (let foo = bar

             if ret then
                 ""
             else
                 "" |> log.LogInformation

             ret)

Problem description

Fantomas was not able to produce the same code after reformatting the result.

It tries to add and remove newlines just before the lazy.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 04/05/2021 16:09:34 - 31922c0

    { config with
                MaxLineLength = 100
                SpaceBeforeUppercaseInvocation = true
                SpaceBeforeClassConstructor = true
                SpaceBeforeMember = true
                SpaceBeforeColon = true
                SpaceBeforeSemicolon = true
                MultilineBlockBracketsOnSameColumn = true
                NewlineBetweenTypeDefinitionAndMembers = true
                KeepIfThenInSameLine = true
                AlignFunctionSignatureToIndentation = true
                AlternativeLongMemberDefinitions = true
                MultiLineLambdaClosingNewline = true
                KeepIndentInBranch = true }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants