Update the upload-artifact CI build action to version 4 #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
commented
Jul 15, 2024
.github/workflows/build_and_test.yml
Outdated
| with: | ||
| name: fake-artifacts | ||
| name: fake-artifacts-${{ matrix.runs-on }} |
There was a problem hiding this comment.
The docs at https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md state that artifacts need unique names with the v4 action
xperiandri
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current CI builds, there are a number of instances of this warning:
In addition, the documentation at https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ documents that the v3 action will be deprecated and not useable later this year.
That doc also says
While v4 of the artifact actions improves upload and download speeds by up to 98%which may or may not effect the intermittent artifact upload timeout that has caused the CI builds to fail a few times recently.