add VSTEST paths for VS2019 #2542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for sending in a PR! Yes makes sense to add this (and I probably can merge it as-is), but couldn't we copy some of the vswhere logic from MSBuild to include future VS version out of the box? |
|
I'm new to the FAKE code base, so I simply extended the solution that was already implemented. Agree replacing what's been done with a call to vswhere makes sense, but seeing this PR merged is more like to spur my motivation to contribute than seeing it rejected. |
|
There has not been any activity in this pull request for the last 3 months so it will be closed in 14 days if there is no activity. |
|
Is there some reason this was never merged? |
|
I don't know. Let's resurrect this and update to support 2022 and MSTest v3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the paths for VS2019 for vstest exe.
Solves #2540