Fake.DotNet.Testing.SpecFlow: Added tests and optimized API #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmonty
changed the title
magicmonty
force-pushed
the
SpecFlowTests
branch
from
b9e4a32 to
236af89
Compare
magicmonty
changed the title
|
Fixed the failing build |
|
@matthid What I'm doing wrong here with the Mono invocation? |
matthid
reviewed
Oct 11, 2018
| if projectFile |> String.isNullOrWhiteSpace | ||
| then | ||
| Trace.traceError "SpecFlow needs a non empty project file!" | ||
| failwithf "SpecFlow needs a non empty project file!" |
There was a problem hiding this comment.
personally I'd probably only use failwithf (or invalidArg)
matthid
approved these changes
Oct 11, 2018
|
Looks good, thanks! I guess it will work in the release/next branch, lets see |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added additional tests for SpecFlowNext and changed the API a bit, so that the required projectFile now has to be given to the run function instead of the Parameters
TODO
help/markdown)