Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip diacritics from letters in search queries #143

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

danelkay93
Copy link
Contributor

@danelkay93 danelkay93 commented Jan 8, 2025

Resolves #142

Description

This pull request resolves #142 by stripping diacritics from letters in search queries and searchable text. Users can now find items regardless of the presence or absence of diacritics in their search terms.

  • Integrated the normalize-text library for text processing.
  • Applied normalization to:
    • Card search
    • Combobox
    • Deck filters

fix: Improve search by normalizing diacritics (fspoettel#142)

Resolves fspoettel#142

This commit improves search functionality by
normalizing diacritics in search queries and
searchable text. This ensures that users can
find items even if they use characters with
diacritics, and vice versa.

- Added `normalize-text` library
- Normalized diacritics in card search
- Normalized diacritics in combobox
- Normalized diacritics in deck filters
```
@danelkay93 danelkay93 force-pushed the fix/normalize-diacritics branch from 7154786 to 6c83c35 Compare January 8, 2025 14:05
@danelkay93 danelkay93 changed the title Normalize diacritics in search functionality fix: strip diacritics from letters in search queries Jan 8, 2025
@danelkay93 danelkay93 marked this pull request as ready for review January 8, 2025 14:10
Copy link
Owner

@fspoettel fspoettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good. 👍 Commented two small nitpicks.

@fspoettel fspoettel merged commit d3a5280 into fspoettel:main Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching for text including letters with diacritics can provide unexpected results
2 participants