feat: enable safari and firefox

fspoettel · Jun 24, 2024 · da7a935 · da7a935
1 parent 1c247aa
commit da7a935
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -27,4 +27,3 @@ jobs:
         with:
           name: playwright-report
           path: playwright-report/
-          retention-days: 30
diff --git a/e2e/settings-taboo.spec.ts b/e2e/settings-taboo.spec.ts
@@ -15,7 +15,7 @@ test("settings (taboo)", async ({ page }) => {
   await expect(page.getByTestId("card-text").first()).toContainText(
     "Mutated. After you succeed at a skill test by 2 or more while investigating: Discover 1 clue at your location. (Limit once per round.)",
   );
-  await expect(page.getByTestId("card-taboo")).toContainText(
+  await expect(page.getByTestId("card-taboo").first()).toContainText(
     "Taboo List Mutated",
   );
 });
diff --git a/playwright.config.ts b/playwright.config.ts
@@ -25,7 +25,7 @@ export default defineConfig({
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
   use: {
     /* Base URL to use in actions like `await page.goto('/')`. */
-    baseURL: "http://localhost:3000",
+    baseURL: process.env.E2E_BASE_URL ?? "http://localhost:3000",
 
     /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
     trace: "on-first-retry",
@@ -38,15 +38,15 @@ export default defineConfig({
       use: { ...devices["Desktop Chrome"] },
     },
 
-    // {
-    //   name: "firefox",
-    //   use: { ...devices["Desktop Firefox"] },
-    // },
+    {
+      name: "firefox",
+      use: { ...devices["Desktop Firefox"] },
+    },
 
-    // {
-    //   name: 'webkit',
-    //   use: { ...devices['Desktop Safari'] },
-    // },
+    {
+      name: "webkit",
+      use: { ...devices["Desktop Safari"] },
+    },
 
     /* Test against mobile viewports. */
     // {