Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the configuration object to match Ionide configuration #332

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

amcguier
Copy link
Contributor

This PR should fix #331.

It also updates the configuration parameters to match the settings used in Ionide which enables some extra code analysis settings (warnings in the configuration).

This also ensures that parameters get passed correctly to the workspace/didChangeConfiguration as well, which was omitted in the previous settings PR.

@amcguier
Copy link
Contributor Author

Any chance someone could rerun the tests, looks like their were temporary timeouts during the package restoration unrelated to my changes.

@juergenhoetzel juergenhoetzel force-pushed the fix-init-args branch 2 times, most recently from 2d75e39 to e6c54f6 Compare March 24, 2023 19:30
Co-authored-by: Andrew McGuier <[email protected]>
Co-authored-by: Jürgen Hötzel <[email protected]>
@juergenhoetzel
Copy link
Collaborator

Nice 👍

I have only removed the eglot-fsharp--set-workspace-args function in the amended commit. eglot already uses the initialization options by calling the

(cl-defmethod eglot-initialization-options ((_server eglot-fsautocomplete)) 
...

@juergenhoetzel juergenhoetzel merged commit 0ce19f2 into fsharp:master Mar 24, 2023
@amcguier
Copy link
Contributor Author

Whoops, I left that in, I cherry picked that initial commit in from a branch I was working on. I have an experimental branch that needs to set that so you can run FsAutoComplete at a solution level rather than on each project individually.

@juergenhoetzel
Copy link
Collaborator

BTW: The actual error in the original initialization option was the invalid fsharp key at the top level of the json object:

-  `(:fSharp ,eglot-fsharp-fsautocomplete-args))
+  eglot-fsharp-fsautocomplete-args)

so I guess fsautcomplete never actually used the init options.

@amcguier
Copy link
Contributor Author

Yeah, I realize that the workspace/DidConfigurationChange call requires the :fSharp node to use the options and the intialize call expects the parameters not to be set there. I'll probably add that back in when I PR the other branch since you might change configurations (I'm working on support for workspace peek/load custom calls)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsac >= 0.59.3: No typecheck results
2 participants