Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save the penguins; run fewer tests in CI #849

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Save the penguins; run fewer tests in CI #849

merged 7 commits into from
Oct 24, 2023

Conversation

carmenbianca
Copy link
Member

The biggest change here is that we will no longer be pushing to the dev tag on Docker.

@carmenbianca carmenbianca requested a review from mxmehl October 24, 2023 08:09
@carmenbianca
Copy link
Member Author

Maybe we should also stop building 3 Docker images, and just publish a single image. Probably Debian? Not sure.

People can build their own 'extra' image in any case.

@carmenbianca carmenbianca force-pushed the less-ci branch 4 times, most recently from 302d117 to 1b88477 Compare October 24, 2023 09:45
@mxmehl
Copy link
Member

mxmehl commented Oct 24, 2023

Maybe we should also stop building 3 Docker images, and just publish a single image. Probably Debian? Not sure.

People can build their own 'extra' image in any case.

OK, I see the point of not creating a Docker image for every dev, especially in all three versions. Let's drop that.

Regarding extra, I'd be fine with dropping it as well, but some people may rely on it. I wonder whether an additional image per release (not commit) makes a huge difference.

Regarding alpine vs. Debian, I strongly suggest to stick with alpine as default and still offer Debian as alternative. If we're speaking about penguins, considering that fsfe/reuse has been downloaded more than 1 million times, the lower traffic makes a larger difference than building one more image per release. Debian on the other hand is also important as it's better in terms of license compliance, and some orgs prefer that.

@carmenbianca
Copy link
Member Author

@mxmehl full ack, let's do that!

@carmenbianca carmenbianca force-pushed the less-ci branch 3 times, most recently from 5c83733 to 802f70e Compare October 24, 2023 11:20
mxmehl
mxmehl reviewed Oct 24, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@carmenbianca carmenbianca force-pushed the less-ci branch 2 times, most recently from e907239 to 0a82aff Compare October 24, 2023 11:29
@carmenbianca carmenbianca mentioned this pull request Oct 24, 2023
Closed
@carmenbianca carmenbianca requested a review from mxmehl October 24, 2023 11:57
mxmehl
mxmehl approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@mxmehl mxmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@carmenbianca
Copy link
Member Author

I had another look at #238. Getting rid of -extra would (still) basically break CircleCI, which is stupid.

I'm going to make the decision to rope openssh-client into the base Alpine image. Being able to git clone is a fairly basic functionality that should be available. The difference in size isn't that big:

$ podman image ls fsfe/reuse
REPOSITORY            TAG            IMAGE ID      CREATED       SIZE
docker.io/fsfe/reuse  latest-debian  439efbe73d17  3 months ago  340 MB
docker.io/fsfe/reuse  latest-extra   ba02bf7cfdbd  3 months ago  114 MB
docker.io/fsfe/reuse  latest         7cc624f34f51  3 months ago  110 MB

(4MB with the latest 2.1 release)

@carmenbianca
Test against fewer Python versions
33844c7 
Let's save the planet and assume that if both 3.8 and 3.12 are
supported, all the versions in between will also work.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
Don't test against multiple OSes for reuse lint
0f2e63c 
Not necessary. We already test against multiple OSes elsewhere.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
Update to Ubuntu 22.04
33a21e8 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
No longer build dev tags
b4533a4 
People can build their own, and they shouldn't depend on our main branch
anyway.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
No longer publish -extra images
97d4649 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
Add change log entry.
d4b6bf1 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
Add openssh-client to main image
b1e93be 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca carmenbianca merged commit 6c3de58 into fsfe:main Oct 24, 2023
@mxmehl
Copy link
Member

mxmehl commented Oct 25, 2023

Sounds fair, thank you for taking an "extra" look ;)

@carmenbianca carmenbianca mentioned this pull request Nov 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmehl mxmehl mxmehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carmenbianca @mxmehl