ZO Character assets #2678
ZO Character assets #2678
Conversation
WalkthroughThe changes introduce a new module that aggregates image assets and several new type definitions and functions in another module. The first file creates a default export containing two image assets. The second file enhances functionality by adding type aliases, importing new types, and defining functions that retrieve or process image assets while adding error handling improvements. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant I as Index Module
participant Cache as Asset Cache
participant Chars as Chars Module
U->>I: Call characterAsset(ck, asset)
I->>Cache: Check for asset
alt Asset exists
Cache-->>I: Return asset
else Asset missing
I->>Chars: Fetch asset for ck and asset
Chars-->>I: Return fetched asset
I->>Cache: Cache the asset
end
I-->>U: Return asset
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[zzz-frontend] [Sat Feb 8 17:42:40 UTC 2025] - Deployed fb5ef17 to https://genshin-optimizer-prs.github.io/pr/2678/zzz-frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Sat Feb 8 18:06:32 UTC 2025] - Deployed c3bb537 to https://genshin-optimizer-prs.github.io/pr/2678/zzz-frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Sat Feb 8 18:35:21 UTC 2025] - Deployed c3bb537 to https://genshin-optimizer-prs.github.io/pr/2678/zzz-frontend (Takes 3-5 minutes after this completes to be available) [Sat Feb 8 18:37:22 UTC 2025] - Deleted deployment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (107)
libs/zzz/assets/src/common/discBackdrop.pngis excluded by!**/*.pnglibs/zzz/assets/src/common/drive.pngis excluded by!**/*.pnglibs/zzz/assets/src/gen/chars/Anby/IconRole01.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Anby/IconRoleCircleAnby.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Anby/IconRoleSelectAnby.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Anby/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Anton/IconRole15.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Anton/IconRoleSelect15.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Anton/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/AstraYao/IconRole36.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/AstraYao/IconRoleCircleAstraYao.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/AstraYao/IconRoleSelectAstraYao.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/AstraYao/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Ben/IconRole16.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Ben/IconRoleSelect16.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Ben/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Billy/IconRole10.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Billy/IconRoleSelect10.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Billy/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Burnice/IconRole32.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Burnice/IconRoleSelect32.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Burnice/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Caesar/IconRole25.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Caesar/IconRoleSelect25.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Caesar/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Corin/IconRole09.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Corin/IconRoleSelect09.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Corin/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Ellen/IconRole21.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Ellen/IconRoleSelect21.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Ellen/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Evelyn/IconRole37.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Evelyn/IconRoleSelect37.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Evelyn/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Grace/IconRole20.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Grace/IconRoleSelect20.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Grace/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Harumasa/IconRole35.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Harumasa/IconRoleSelect35.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Harumasa/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Jane/IconRole24.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Jane/IconRoleSelect24.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Jane/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Koleda/IconRole14.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Koleda/IconRoleSelect14.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Koleda/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Lighter/IconRole26.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Lighter/IconRoleSelect26.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Lighter/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Lucy/IconRole27.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Lucy/IconRoleSelect27.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Lucy/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Lycaon/IconRole18.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Lycaon/IconRoleSelect18.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Lycaon/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Miyabi/IconRole13.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Miyabi/IconRoleSelect13.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Miyabi/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Nekomata/IconRole11.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Nekomata/IconRoleSelect11.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Nekomata/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Nicole/IconRole12.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Nicole/IconRoleSelect12.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Nicole/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Piper/IconRole28.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Piper/IconRoleSelect28.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Piper/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/QingYi/IconRole29.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/QingYi/IconRoleSelect29.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/QingYi/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Rina/IconRole22.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Rina/IconRoleSelect22.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Rina/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Seth/IconRole30.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Seth/IconRoleSelect30.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Seth/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Soldier11/IconRole05.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Soldier11/IconRoleSelect05.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Soldier11/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Soukaku/IconRole17.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Soukaku/IconRoleSelect17.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Soukaku/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Yanagi/IconRole31.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Yanagi/IconRoleSelect31.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/Yanagi/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/ZhuYuan/IconRole23.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/ZhuYuan/IconRoleSelect23.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/chars/ZhuYuan/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/common/SkillCore.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/common/SkillEvade.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/common/SkillNormal.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/common/SkillQTE.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/common/SkillSpecial.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/common/SkillSwitch.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/common/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/rarity/RANK_A.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/rarity/RANK_B.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/rarity/RANK_S.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/rarity/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/speciality/IconAnomaly.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/speciality/IconAttack.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/speciality/IconDefense.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/speciality/IconStun.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/speciality/IconSupport.pngis excluded by!**/*.png,!**/gen/**libs/zzz/assets/src/gen/speciality/index.tsis excluded by!**/gen/**
📒 Files selected for processing (3)
libs/zzz/assets/src/common/index.ts(1 hunks)libs/zzz/assets/src/index.ts(1 hunks)libs/zzz/consts/src/character.ts(0 hunks)
💤 Files with no reviewable changes (1)
- libs/zzz/consts/src/character.ts
🧰 Additional context used
🪛 Biome (1.9.4)
libs/zzz/assets/src/index.ts
[error] 28-28: Forbidden non-null assertion.
(lint/style/noNonNullAssertion)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: lint
🔇 Additional comments (4)
libs/zzz/assets/src/index.ts (3)
1-22: Looks good to me... yawnsThe imports and type definitions are well-organized. I've been staring at type definitions all night, and these ones actually make sense.
36-38: Simple and sweet, just like my coffee at midnight.The null check is there, it returns what it should. No complaints from this sleep-deprived dev.
40-46: Copy-paste done right for once... sips coffeeThese functions follow the same pattern consistently. It's refreshing to see consistency at this hour.
libs/zzz/assets/src/common/index.ts (1)
1-9: Simple and clean... just what my tired brain needs.Nice use of
as constfor type safety. The generated index file is doing exactly what it should - no more, no less.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (4)
libs/zzz/assets/src/gen/chars/PulchraFeliny/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/SilverAnby/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/Trigger/index.tsis excluded by!**/gen/**libs/zzz/assets/src/gen/chars/index.tsis excluded by!**/gen/**
📒 Files selected for processing (1)
libs/zzz/assets/src/index.ts(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
libs/zzz/assets/src/index.ts
[error] 28-28: Forbidden non-null assertion.
(lint/style/noNonNullAssertion)
🔇 Additional comments (8)
libs/zzz/assets/src/index.ts (8)
1-7: All these imports look tidy.
Somnia, caffeinated and scanning... no immediate red flags here. Nice and clean.
14-22: New type definitions look concise.
Somnia appreciates the succinctness of these type aliases—no extra fluff to keep me awake at night.
28-28: Avoid the non-null assertion.
Somnia’s eyes twitch whenever I see a “!”. It's safer to replace it with optional chaining or a default, like so:- return characterAssetCache.get(cacheKey)! + return characterAssetCache.get(cacheKey) ?? ''🧰 Tools
🪛 Biome (1.9.4)
[error] 28-28: Forbidden non-null assertion.
(lint/style/noNonNullAssertion)
25-34: Good caching approach, but let's keep an eye on potential object shape changes.
Somnia wonders if you might eventually store more fields than just strings. If so, watch out for any mismatch in theRecord<characterAssetKey, ...>shape. For now, though, everything lines up fine.🧰 Tools
🪛 Biome (1.9.4)
[error] 28-28: Forbidden non-null assertion.
(lint/style/noNonNullAssertion)
36-38: discDefIcon logic is straightforward.
Somnia sees no fancy footwork here—just a clean fallback to an empty string. Perfect for night-time debugging.
40-42: specialityDefIcon reads well.
Somnia has no nightmares about this function. It's simple, returns a string or empty, easy to maintain.
44-46: rarityDefIcon remains consistent.
Somnia notes that this is aligned with the pattern of returning either from a lookup or an empty string. All good.
52-53: commonDefImages is consistent with your icon approach.
Somnia likes the empty string fallback—less chance of a late-night “undefined” meltdown.
| export function commonDefIcon(key: commonKey) { | ||
| return key ? common[key] : '' | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
commonDefIcon pattern matches the others nicely.
Somnia sees a repeating pattern across these “defIcon” functions—maybe a future DRY refactor, but not urgent.
Describe your changes
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.Summary by CodeRabbit