Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update silly wisher art #2677

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Update silly wisher art #2677

merged 3 commits into from
Feb 8, 2025

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Feb 8, 2025

Describe your changes

  • Update silly wisher images to 0.53
  • The way we extract strings has been broken for a while, so no update there

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Summary by CodeRabbit

  • Chores
    • Updated the module's release version to mark the latest iteration.
  • New Features
    • Added several new character portraits to enhance visual displays.
    • Expanded the character roster by reintroducing previously removed characters.
  • Bug Fixes
    • Corrected a portrait image reference to ensure accurate character displays.

Copy link
Contributor

coderabbitai bot commented Feb 8, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • libs/gi/silly-wisher/src/portraits/portrait_heizou.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_tighnari.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/potrait_barbara.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request bumps the version of the silly-wisher module from 0.42 to 0.53 and updates the data assets. New character portrait imports have been added in the portraits module, including a fix for an incorrect filename. Similarly, the splash module now incorporates these new characters into its charCards object while reinstating previously removed entries. Overall, the changes expand the available character set and update corresponding references without altering the core logic.

Changes

File(s) Change Summary
libs/.../VERSION Updated version number from 0.42 to 0.53.
libs/.../src/portraits/index.ts, libs/.../src/splash/index.ts Added new character imports (Chasca, Citlali, Clorinde, Emilie, Kachina, Kinich, LanYan, Mavuika, Mualani, Ororon, Sethos, Sigewinne, Xilonen); corrected ShikanoinHeizou file reference in portraits; reinstated AratakiItto and Gaming in splash.

Sequence Diagram(s)

Suggested reviewers

  • frzyc

Poem

In the dark of code, amidst caffeine's glow,
New portraits shine where tired keys do flow.
Bugs once lurked, now banished away,
Characters come alive to brighten the gray.
Sleep may evade, but our code sings tonight!
(¯―¯٥)
Happy releasing, even at 3 AM.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0567e74 and a210cb2.

⛔ Files ignored due to path filters (188)
  • libs/gi/silly-wisher/src/portraits/portrait_aether.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_albedo.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_alhaitham.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_aloy.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_amber.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_arlecchino.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_ayaka.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_ayato.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_baizhu.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_barbara.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_beidou.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_bennett.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_candace.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_charlotte.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_chasca.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_chevreuse.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_chiori.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_chongyun.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_citlali.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_clorinde.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_collei.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_cyno.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_dehya.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_diluc.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_diona.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_dori.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_emilie.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_eula.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_faruzan.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_fischl.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_freminet.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_furina.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_gaming.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_ganyu.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_gorou.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_hutao.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_itto.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_jean.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_kachina.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_kaeya.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_kaveh.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_kazuha.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_keqing.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_kinich.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_kirara.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_klee.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_kokomi.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_kuki.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_lanyan.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_layla.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_lisa.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_lumine.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_lynette.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_lyney.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_mavuika.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_mika.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_mona.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_mualani.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_nahida.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_navia.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_neuvillette.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_nilou.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_ningguang.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_noelle.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_ororon.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_qiqi.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_raiden.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_razor.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_rosaria.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_sara.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_sayu.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_sethos.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_shenhe.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_sigewinne.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_sucrose.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_tartaglia.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_thoma.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_tightnari.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_venti.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_wanderer.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_wriothesley.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_xiangling.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_xianyun.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_xiao.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_xilonen.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_xingqiu.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_xinyan.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_yae.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_yanfei.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_yaoyao.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_yelan.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_yoimiya.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_yunjin.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/portraits/portrait_zhongli.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_aether.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_albedo.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_alhaitham.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_amber.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_arlecchino.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_ayaka.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_ayato.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_baizhu.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_barbara.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_beidou.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_bennett.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_candace.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_charlotte.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_chasca.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_chevreuse.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_chiori.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_chongyun.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_citlali.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_clorinde.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_collei.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_cyno.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_dehya.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_diluc.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_diona.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_dori.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_emilie.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_eula.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_faruzan.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_fischl.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_freminet.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_furina.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_gaming.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_ganyu.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_gorou.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_heizou.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_hutao.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_itto.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_jean.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_kachina.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_kaeya.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_kaveh.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_kazuha.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_keqing.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_kinich.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_kirara.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_klee.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_kokomi.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_kuki.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_lanyan.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_layla.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_lisa.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_lumine.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_lynette.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_lyney.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_mavuika.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_mika.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_mona.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_mualani.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_nahida.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_navia.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_neuvillette.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_nilou.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_ningguang.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_noelle.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_ororon.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_qiqi.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_raiden.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_razor.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_rosaria.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_sara.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_sayu.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_sethos.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_shenhe.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_sigewinne.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_sucrose.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_tartaglia.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_thoma.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_tighnari.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_venti.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_wanderer.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_wriothesley.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_xiangling.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_xianyun.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_xiao.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_xilonen.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_xingqiu.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_xinyan.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_yae.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_yanfei.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_yaoyao.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_yelan.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_yoimiya.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_yunjin.png is excluded by !**/*.png
  • libs/gi/silly-wisher/src/splash/splash_zhongli.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • libs/gi/silly-wisher/VERSION (1 hunks)
  • libs/gi/silly-wisher/src/portraits/index.ts (6 hunks)
  • libs/gi/silly-wisher/src/splash/index.ts (5 hunks)
🧰 Additional context used
🪛 GitHub Actions: Build GO (WR) for 2677 - Update silly wisher art
libs/gi/silly-wisher/src/portraits/index.ts

[error] 1-1: Could not resolve "./portrait_heizou.png" from "../../libs/gi/silly-wisher/src/portraits/index.ts"

🪛 GitHub Actions: Build GO-next for 2677 - Update silly wisher art
libs/gi/silly-wisher/src/portraits/index.ts

[error] 1-1: Module not found: Can't resolve './portrait_heizou.png'


[error] 2-2: Module not found: Can't resolve './portrait_tighnari.png'

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: lint
🔇 Additional comments (3)
libs/gi/silly-wisher/src/portraits/index.ts (1)

17-17: Verify new character portrait images exist.

rubs eyes I see you've added quite a few new character portraits. Could you double-check that all these new image files are actually included in the commit? Would hate to have more build failures like the ones we're seeing with heizou and tighnari.

Also applies to: 21-22, 29-29, 42-42, 47-47, 52-52, 58-58, 61-61, 68-68, 75-75, 77-77, 88-88

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Check if all new portrait image files exist
for char in chasca citlali clorinde emilie kachina kinich lanyan mavuika mualani ororon sethos sigewinne xilonen; do
  if [ ! -f "libs/gi/silly-wisher/src/portraits/portrait_${char,,}.png" ]; then
    echo "Missing portrait file: portrait_${char,,}.png"
  fi
done

Length of output: 2440


All new character portrait images are present.

I double-checked with the script, and no missing portrait files were reported. Every image—even for the extended list of characters—is accounted for in the commit, so there shouldn’t be any build issues related to missing images.

libs/gi/silly-wisher/src/splash/index.ts (1)

16-16: Verify new character splash images exist.

fighting to stay awake Similar to the portraits, we should make sure all these new splash images are actually included. Let me check that real quick...

Also applies to: 20-21, 28-28, 41-41, 46-46, 51-51, 57-57, 60-60, 67-67, 74-74, 76-76, 87-87

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Check if all new splash image files exist
for char in chasca citlali clorinde emilie kachina kinich lanyan mavuika mualani ororon sethos sigewinne xilonen; do
  if [ ! -f "libs/gi/silly-wisher/src/splash/splash_${char,,}.png" ]; then
    echo "Missing splash file: splash_${char,,}.png"
  fi
done

Length of output: 2375


All splash images are present.

I've double-checked with the provided script, which didn't flag any missing splash files. Therefore, all the splash assets (including the one imported as Chasca) exist in the designated directory, and we don't face the previous build issues like with the portraits.

libs/gi/silly-wisher/VERSION (1)

1-1: Verify version bump follows semantic versioning.

yawns loudly That's quite a version jump from 0.42 to 0.53. Just want to make sure this follows our semantic versioning guidelines. Could you confirm if this is intentional?

Usually, for just adding new characters, we might only bump the minor or patch version... dozes off momentarily ...unless there are breaking changes I'm not seeing?

libs/gi/silly-wisher/src/portraits/index.ts Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 8, 2025

[frontend] [Sat Feb 8 16:41:46 UTC 2025] - Deployed 5f1d343 to https://genshin-optimizer-prs.github.io/pr/2677/frontend (Takes 3-5 minutes after this completes to be available)

[Sat Feb 8 19:09:19 UTC 2025] - Deleted deployment

[frontend] [Sun Feb 9 04:45:56 UTC 2025] - Deployed 1ee58f9 to https://genshin-optimizer-prs.github.io/pr/2677/frontend (Takes 3-5 minutes after this completes to be available)

@nguyentvan7 nguyentvan7 merged commit 1ee58f9 into master Feb 8, 2025
8 checks passed
@nguyentvan7 nguyentvan7 deleted the van/go/silly2 branch February 8, 2025 19:08
@frzyc frzyc added the GO Genshin Optimizer label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GO Genshin Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants