-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update silly wisher art #2677
Update silly wisher art #2677
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe pull request bumps the version of the silly-wisher module from 0.42 to 0.53 and updates the data assets. New character portrait imports have been added in the portraits module, including a fix for an incorrect filename. Similarly, the splash module now incorporates these new characters into its charCards object while reinstating previously removed entries. Overall, the changes expand the available character set and update corresponding references without altering the core logic. Changes
Sequence Diagram(s)Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (188)
libs/gi/silly-wisher/src/portraits/portrait_aether.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_albedo.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_alhaitham.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_aloy.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_amber.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_arlecchino.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_ayaka.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_ayato.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_baizhu.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_barbara.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_beidou.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_bennett.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_candace.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_charlotte.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_chasca.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_chevreuse.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_chiori.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_chongyun.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_citlali.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_clorinde.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_collei.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_cyno.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_dehya.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_diluc.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_diona.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_dori.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_emilie.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_eula.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_faruzan.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_fischl.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_freminet.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_furina.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_gaming.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_ganyu.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_gorou.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_hutao.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_itto.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_jean.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_kachina.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_kaeya.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_kaveh.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_kazuha.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_keqing.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_kinich.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_kirara.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_klee.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_kokomi.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_kuki.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_lanyan.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_layla.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_lisa.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_lumine.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_lynette.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_lyney.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_mavuika.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_mika.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_mona.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_mualani.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_nahida.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_navia.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_neuvillette.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_nilou.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_ningguang.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_noelle.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_ororon.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_qiqi.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_raiden.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_razor.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_rosaria.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_sara.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_sayu.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_sethos.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_shenhe.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_sigewinne.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_sucrose.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_tartaglia.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_thoma.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_tightnari.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_venti.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_wanderer.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_wriothesley.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_xiangling.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_xianyun.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_xiao.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_xilonen.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_xingqiu.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_xinyan.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_yae.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_yanfei.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_yaoyao.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_yelan.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_yoimiya.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_yunjin.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/portraits/portrait_zhongli.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_aether.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_albedo.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_alhaitham.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_amber.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_arlecchino.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_ayaka.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_ayato.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_baizhu.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_barbara.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_beidou.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_bennett.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_candace.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_charlotte.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_chasca.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_chevreuse.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_chiori.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_chongyun.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_citlali.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_clorinde.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_collei.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_cyno.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_dehya.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_diluc.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_diona.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_dori.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_emilie.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_eula.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_faruzan.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_fischl.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_freminet.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_furina.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_gaming.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_ganyu.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_gorou.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_heizou.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_hutao.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_itto.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_jean.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_kachina.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_kaeya.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_kaveh.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_kazuha.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_keqing.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_kinich.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_kirara.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_klee.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_kokomi.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_kuki.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_lanyan.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_layla.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_lisa.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_lumine.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_lynette.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_lyney.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_mavuika.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_mika.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_mona.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_mualani.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_nahida.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_navia.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_neuvillette.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_nilou.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_ningguang.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_noelle.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_ororon.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_qiqi.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_raiden.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_razor.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_rosaria.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_sara.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_sayu.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_sethos.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_shenhe.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_sigewinne.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_sucrose.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_tartaglia.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_thoma.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_tighnari.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_venti.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_wanderer.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_wriothesley.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_xiangling.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_xianyun.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_xiao.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_xilonen.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_xingqiu.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_xinyan.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_yae.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_yanfei.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_yaoyao.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_yelan.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_yoimiya.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_yunjin.png
is excluded by!**/*.png
libs/gi/silly-wisher/src/splash/splash_zhongli.png
is excluded by!**/*.png
📒 Files selected for processing (3)
libs/gi/silly-wisher/VERSION
(1 hunks)libs/gi/silly-wisher/src/portraits/index.ts
(6 hunks)libs/gi/silly-wisher/src/splash/index.ts
(5 hunks)
🧰 Additional context used
🪛 GitHub Actions: Build GO (WR) for 2677 - Update silly wisher art
libs/gi/silly-wisher/src/portraits/index.ts
[error] 1-1: Could not resolve "./portrait_heizou.png" from "../../libs/gi/silly-wisher/src/portraits/index.ts"
🪛 GitHub Actions: Build GO-next for 2677 - Update silly wisher art
libs/gi/silly-wisher/src/portraits/index.ts
[error] 1-1: Module not found: Can't resolve './portrait_heizou.png'
[error] 2-2: Module not found: Can't resolve './portrait_tighnari.png'
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: lint
🔇 Additional comments (3)
libs/gi/silly-wisher/src/portraits/index.ts (1)
17-17
: Verify new character portrait images exist.rubs eyes I see you've added quite a few new character portraits. Could you double-check that all these new image files are actually included in the commit? Would hate to have more build failures like the ones we're seeing with heizou and tighnari.
Also applies to: 21-22, 29-29, 42-42, 47-47, 52-52, 58-58, 61-61, 68-68, 75-75, 77-77, 88-88
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Check if all new portrait image files exist for char in chasca citlali clorinde emilie kachina kinich lanyan mavuika mualani ororon sethos sigewinne xilonen; do if [ ! -f "libs/gi/silly-wisher/src/portraits/portrait_${char,,}.png" ]; then echo "Missing portrait file: portrait_${char,,}.png" fi doneLength of output: 2440
All new character portrait images are present.
I double-checked with the script, and no missing portrait files were reported. Every image—even for the extended list of characters—is accounted for in the commit, so there shouldn’t be any build issues related to missing images.
libs/gi/silly-wisher/src/splash/index.ts (1)
16-16
: Verify new character splash images exist.fighting to stay awake Similar to the portraits, we should make sure all these new splash images are actually included. Let me check that real quick...
Also applies to: 20-21, 28-28, 41-41, 46-46, 51-51, 57-57, 60-60, 67-67, 74-74, 76-76, 87-87
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Check if all new splash image files exist for char in chasca citlali clorinde emilie kachina kinich lanyan mavuika mualani ororon sethos sigewinne xilonen; do if [ ! -f "libs/gi/silly-wisher/src/splash/splash_${char,,}.png" ]; then echo "Missing splash file: splash_${char,,}.png" fi doneLength of output: 2375
All splash images are present.
I've double-checked with the provided script, which didn't flag any missing splash files. Therefore, all the splash assets (including the one imported as Chasca) exist in the designated directory, and we don't face the previous build issues like with the portraits.
libs/gi/silly-wisher/VERSION (1)
1-1
: Verify version bump follows semantic versioning.yawns loudly That's quite a version jump from 0.42 to 0.53. Just want to make sure this follows our semantic versioning guidelines. Could you confirm if this is intentional?
Usually, for just adding new characters, we might only bump the minor or patch version... dozes off momentarily ...unless there are breaking changes I'm not seeing?
[frontend] [Sat Feb 8 16:41:46 UTC 2025] - Deployed 5f1d343 to https://genshin-optimizer-prs.github.io/pr/2677/frontend (Takes 3-5 minutes after this completes to be available) [Sat Feb 8 19:09:19 UTC 2025] - Deleted deployment [frontend] [Sun Feb 9 04:45:56 UTC 2025] - Deployed 1ee58f9 to https://genshin-optimizer-prs.github.io/pr/2677/frontend (Takes 3-5 minutes after this completes to be available) |
Describe your changes
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.Summary by CodeRabbit