Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zo build sorting #2611

Merged
merged 1 commit into from
Jan 25, 2025
Merged

fix zo build sorting #2611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions libs/sr/solver/src/parentWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,15 +188,10 @@ async function start({
})
)

// Trigger spinner on UI
if (results.length > MAX_BUILDS) {
results.sort((a, b) => b.value - a.value)
results = results.slice(0, MAX_BUILDS)
}
// Send back results, which can take a few seconds
postMessage({
resultType: 'done',
buildResults: results,
buildResults: results.sort((a, b) => b.value - a.value).slice(0, 10), // TODO: take numBuilds from opt UI
frzyc marked this conversation as resolved.
Show resolved Hide resolved
})
}

Expand Down
7 changes: 1 addition & 6 deletions libs/zzz/solver/src/parentWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,15 +176,10 @@ async function start({
})
)

// Trigger spinner on UI
if (results.length > MAX_BUILDS) {
results.sort((a, b) => b.value - a.value)
results = results.slice(0, MAX_BUILDS)
}
// Send back results, which can take a few seconds
postMessage({
resultType: 'done',
buildResults: results.slice(0, 10), // TODO: take numBuilds from opt UI
buildResults: results.sort((a, b) => b.value - a.value).slice(0, 10), // TODO: take numBuilds from opt UI
})
}

Expand Down
Loading