Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xilonen + new weapons #2486

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Add Xilonen + new weapons #2486

merged 4 commits into from
Oct 9, 2024

Conversation

nguyentvan7
Copy link
Collaborator

Describe your changes

  • Add Xilonen
  • Add Peak Patrol Song (sword)
  • Add Sturdy Bone (sword)
  • Add Fruitful Hook (claymore)
  • Add Mountain-Bracing Bolt (polearm)

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 requested a review from frzyc October 8, 2024 18:47
Copy link
Contributor

github-actions bot commented Oct 8, 2024

[frontend] [Tue Oct 8 18:52:36 UTC 2024] - Deployed 6f543d3 to https://genshin-optimizer-prs.github.io/pr/2486/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Oct 9 00:08:46 UTC 2024] - Deleted deployment

Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:clueless:

@nguyentvan7 nguyentvan7 merged commit db663dd into master Oct 9, 2024
8 checks passed
@nguyentvan7 nguyentvan7 deleted the van/go/xilo branch October 9, 2024 00:08
macerator-yaro pushed a commit to macerator-yaro/genshin-optimizer that referenced this pull request Oct 29, 2024
* Update dm

* Add Xilonen + new weapons

* Gen files

* Update meta/gi-formula
macerator-yaro pushed a commit to macerator-yaro/genshin-optimizer that referenced this pull request Oct 29, 2024
* Update dm

* Add Xilonen + new weapons

* Gen files

* Update meta/gi-formula
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants