Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Favicon from teams character picture #1736

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

HassnHamada
Copy link
Contributor

@HassnHamada HassnHamada commented Mar 15, 2024

Describe your changes

Remove favourite icon from character card in teams

Issue or discord link

Testing/validation

Before
Screenshot 2024-03-16 at 12 24 31 AM
After
Screenshot 2024-03-16 at 12 24 41 AM

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Mar 15, 2024

[frontend] [Fri Mar 15 22:32:20 UTC 2024] - Deployed 8fcf062 to https://genshin-optimizer-prs.github.io/pr/1736/frontend (Takes 3-5 minutes after this completes to be available)

[Sat Mar 16 03:19:42 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 merged commit 97cb36c into frzyc:master Mar 16, 2024
5 checks passed
@HassnHamada HassnHamada deleted the hide-fav-icon branch March 16, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fav icon within teams card
2 participants