Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make geo resonance pt1 only apply to active char #1708

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

nguyentvan7
Copy link
Collaborator

Describe your changes

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 requested a review from frzyc March 13, 2024 22:02
Copy link
Contributor

[frontend] [Wed Mar 13 22:06:28 UTC 2024] - Deployed 5d5a18a to https://genshin-optimizer-prs.github.io/pr/1708/frontend (Takes 3-5 minutes after this completes to be available)

@nguyentvan7 nguyentvan7 merged commit b3c5a44 into master Mar 14, 2024
5 checks passed
@nguyentvan7 nguyentvan7 deleted the van/go/geoActive branch March 14, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants