Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various teambuffs that relied on specific active character assumptions #1672

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Mar 12, 2024

Describe your changes

  • Fixed various buffs that had pre-teams assumptions on active character/who could be optimized for
  • Fixed display of various teambuffs with assumptions pre-teams
  • Updated Calamity Queller to determine off-field state automatically

Issue or discord link

Testing/validation

Tested each change and ensured they were performing as expected

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 requested a review from frzyc March 12, 2024 20:30
Copy link
Contributor

github-actions bot commented Mar 12, 2024

[frontend] [Tue Mar 12 20:33:55 UTC 2024] - Deployed f7b54c0 to https://genshin-optimizer-prs.github.io/pr/1672/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Mar 12 20:49:43 UTC 2024] - Deleted deployment

@nguyentvan7 nguyentvan7 merged commit 279b675 into master Mar 12, 2024
5 checks passed
@nguyentvan7 nguyentvan7 deleted the van/go/fixXiphos branch March 12, 2024 20:49
RobberToe added a commit to RobberToe/genshin-optimizer that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xiphos teambuff not working in certain cases
2 participants