Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4.5 content #1667

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Add 4.5 content #1667

merged 5 commits into from
Mar 13, 2024

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Mar 12, 2024

Describe your changes

  • Add Chiori
  • Add Uraku Misugiri
  • Add Dialogue of the Desert Sages
  • Backfill gi-formula changes from past few patches

Issue or discord link

Testing/validation

Validated strings and sheet behavior

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@nguyentvan7 nguyentvan7 requested a review from frzyc March 12, 2024 18:48
Copy link
Contributor

github-actions bot commented Mar 12, 2024

[frontend] [Tue Mar 12 18:53:05 UTC 2024] - Deployed 94a2396 to https://genshin-optimizer-prs.github.io/pr/1667/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 12 18:58:07 UTC 2024] - Deployed d37b555 to https://genshin-optimizer-prs.github.io/pr/1667/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 12 21:00:20 UTC 2024] - Deployed d79a2af to https://genshin-optimizer-prs.github.io/pr/1667/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 12 21:08:36 UTC 2024] - Deployed df35b40 to https://genshin-optimizer-prs.github.io/pr/1667/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Mar 13 00:49:59 UTC 2024] - Deleted deployment

Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nguyentvan7 nguyentvan7 merged commit 0fdb5f1 into master Mar 13, 2024
5 checks passed
@nguyentvan7 nguyentvan7 deleted the van/go/snipsnip branch March 13, 2024 00:49
RobberToe added a commit to RobberToe/genshin-optimizer that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants