Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cards #1664

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Build cards #1664

merged 3 commits into from
Mar 12, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Mar 12, 2024

Describe your changes

Convert the horizontal rows of builds to cards
image

image

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc self-assigned this Mar 12, 2024
@frzyc frzyc requested a review from nguyentvan7 March 12, 2024 06:12
Copy link
Contributor

github-actions bot commented Mar 12, 2024

[frontend] [Tue Mar 12 06:16:15 UTC 2024] - Deployed a0e43bc to https://genshin-optimizer-prs.github.io/pr/1664/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 12 06:21:43 UTC 2024] - Deployed c02adea to https://genshin-optimizer-prs.github.io/pr/1664/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 12 08:10:21 UTC 2024] - Deployed f93d375 to https://genshin-optimizer-prs.github.io/pr/1664/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Mar 12 20:21:08 UTC 2024] - Deployed 249a11c to https://genshin-optimizer-prs.github.io/pr/1664/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Mar 12 20:47:57 UTC 2024] - Deleted deployment

@nguyentvan7
Copy link
Collaborator

Looks like some missing bottom padding here
image

Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small padding change, looks amazing otherwise

@frzyc frzyc requested a review from nguyentvan7 March 12, 2024 20:17
@frzyc frzyc merged commit 699d2de into master Mar 12, 2024
5 checks passed
@frzyc frzyc deleted the build_cards branch March 12, 2024 20:47
RobberToe added a commit to RobberToe/genshin-optimizer that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants