Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor scanner fixes #1361

Merged
merged 3 commits into from
Dec 9, 2023
Merged

Some minor scanner fixes #1361

merged 3 commits into from
Dec 9, 2023

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Dec 4, 2023

Describe your changes

  • Add more processing for mainstats
  • Fix minor issue with overtly white backgrounds
  • Add the debug screen to dev env

Testing/validation

Tested against Godlander's screenshots

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

[frontend] [Mon Dec 4 06:54:03 UTC 2023] - Building version

[gi-frontend] [Mon Dec 4 17:10:06 UTC 2023] - Building version fc44afa

[frontend] [Mon Dec 4 17:10:12 UTC 2023] - Building version fc44afa

[sr-frontend] [Mon Dec 4 17:10:17 UTC 2023] - Building version fc44afa

[sr-frontend] [Mon Dec 4 17:11:29 UTC 2023] - Deployed fc44afa to https://genshin-optimizer-prs.github.io/pr/1361/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Dec 4 17:12:28 UTC 2023] - Deployed fc44afa to https://genshin-optimizer-prs.github.io/pr/1361/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Mon Dec 4 17:12:39 UTC 2023] - Deployed fc44afa to https://genshin-optimizer-prs.github.io/pr/1361/gi-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Dec 9 06:06:03 UTC 2023] - Building version a031c3f

[sr-frontend] [Sat Dec 9 06:06:04 UTC 2023] - Building version a031c3f

[gi-frontend] [Sat Dec 9 06:06:06 UTC 2023] - Building version a031c3f

[sr-frontend] [Sat Dec 9 06:07:13 UTC 2023] - Deployed a031c3f to https://genshin-optimizer-prs.github.io/pr/1361/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Dec 9 06:08:15 UTC 2023] - Deployed a031c3f to https://genshin-optimizer-prs.github.io/pr/1361/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Sat Dec 9 06:08:33 UTC 2023] - Deployed a031c3f to https://genshin-optimizer-prs.github.io/pr/1361/gi-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Sat Dec 9 17:53:14 UTC 2023] - Building version 4779eb0

[sr-frontend] [Sat Dec 9 17:53:15 UTC 2023] - Building version 4779eb0

[frontend] [Sat Dec 9 17:53:31 UTC 2023] - Building version 4779eb0

[sr-frontend] [Sat Dec 9 17:54:21 UTC 2023] - Deployed 4779eb0 to https://genshin-optimizer-prs.github.io/pr/1361/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Sat Dec 9 17:55:39 UTC 2023] - Deployed 4779eb0 to https://genshin-optimizer-prs.github.io/pr/1361/gi-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Dec 9 17:55:50 UTC 2023] - Deployed 4779eb0 to https://genshin-optimizer-prs.github.io/pr/1361/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Dec 9 19:31:19 UTC 2023] - Building version 4779eb0

[frontend] [Sat Dec 9 19:31:21 UTC 2023] - Building version 4779eb0

[gi-frontend] [Sat Dec 9 19:31:39 UTC 2023] - Building version 4779eb0

[sr-frontend] [Sat Dec 9 19:32:25 UTC 2023] - Deployed 4779eb0 to https://genshin-optimizer-prs.github.io/pr/1361/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Dec 9 19:33:30 UTC 2023] - Deployed 4779eb0 to https://genshin-optimizer-prs.github.io/pr/1361/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Sat Dec 9 19:34:16 UTC 2023] - Deployed 4779eb0 to https://genshin-optimizer-prs.github.io/pr/1361/gi-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Sat Dec 9 19:53:07 UTC 2023] - Building version 7c61ec1

[gi-frontend] [Sat Dec 9 19:53:10 UTC 2023] - Building version 7c61ec1

[frontend] [Sat Dec 9 19:53:13 UTC 2023] - Building version 7c61ec1

[sr-frontend] [Sat Dec 9 19:54:15 UTC 2023] - Deployed 7c61ec1 to https://genshin-optimizer-prs.github.io/pr/1361/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat Dec 9 19:55:21 UTC 2023] - Deployed 7c61ec1 to https://genshin-optimizer-prs.github.io/pr/1361/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Sat Dec 9 19:55:37 UTC 2023] - Deployed 7c61ec1 to https://genshin-optimizer-prs.github.io/pr/1361/gi-frontend (Takes 3-5 minutes after this completes to be available)

[Sat Dec 9 20:09:00 UTC 2023] - Deleted deployment

Repository owner deleted a comment from github-actions bot Dec 4, 2023
@nguyentvan7 nguyentvan7 added bug Something isn't working and removed bug Something isn't working labels Dec 4, 2023
@frzyc frzyc assigned frzyc and unassigned nguyentvan7 Dec 9, 2023
@frzyc frzyc requested a review from nguyentvan7 December 9, 2023 06:05
@frzyc frzyc added the showDevComponents Set on a PR to show components that are normally development-only label Dec 9, 2023
@frzyc frzyc added showDevComponents Set on a PR to show components that are normally development-only and removed showDevComponents Set on a PR to show components that are normally development-only labels Dec 9, 2023
@frzyc frzyc merged commit 5bf9042 into master Dec 9, 2023
9 checks passed
@frzyc frzyc deleted the frzyc/scanner_fix branch December 9, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showDevComponents Set on a PR to show components that are normally development-only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants