Fixes: Clear TC autocomplete on selection, Allow commas in number inp… (

#2597) * Fixes: Clear TC autocomplete on selection, Allow commas in number inputs, Allow ctrl+v on artifact editor * Resolve comments --------- Co-authored-by: Failchon <[email protected]>
frzyc · Jan 16, 2025 · beb669d · beb669d
1 parent 3fd901d
commit beb669d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/libs/common/ui/src/components/NumberInputLazy.tsx b/libs/common/ui/src/components/NumberInputLazy.tsx
@@ -25,7 +25,8 @@ export function NumberInputLazy({
   }, [valueProp])
 
   const saveValue = () => {
-    let num = float ? parseFloat(value) : parseInt(value)
+    const normalizedValue = float ? value.replace(',', '.') : value
+    let num = float ? parseFloat(normalizedValue) : parseInt(normalizedValue)
     if (isNaN(num)) {
       num = 0
       setValue(num.toString())
@@ -48,7 +49,7 @@ export function NumberInputLazy({
   ) => {
     const val = event.target.value
 
-    if (val.match(float ? /[^0-9.-]/ : /[^0-9-]/)) {
+    if (val.match(float ? /[^0-9.,-]/ : /[^0-9-]/)) {
       return event.preventDefault()
     }
 

diff --git a/.../CharacterDisplay/Tabs/TabTheorycraft/ArtifactMainStatAndSetEditor/ArtifactSetsEditor.tsx b/.../CharacterDisplay/Tabs/TabTheorycraft/ArtifactMainStatAndSetEditor/ArtifactSetsEditor.tsx
@@ -47,6 +47,7 @@ export function ArtifactSetsEditor({
           artSetKey={''}
           setArtSetKey={setSet}
           label={'New Artifact Set'}
+          blurOnSelect={true}
           getOptionDisabled={({ key }) =>
             Object.keys(artSet).includes(key as ArtifactSetKey) ||
             !key ||

diff --git a/libs/gi/ui/src/components/artifact/editor/index.tsx b/libs/gi/ui/src/components/artifact/editor/index.tsx
@@ -136,6 +136,8 @@ const InputInvis = styled('input')({
   display: 'none',
 })
 
+const LineBreak = styled('br')()
+
 function getDefaultSlotKey(
   artifactSet?: ArtifactSetKey
 ): Extract<ArtifactSlotKey, 'flower' | 'circlet'> {
@@ -649,6 +651,8 @@ export function ArtifactEditor({
                             >
                               {t('editor.uploadBtn')}
                             </Button>
+                            {/* https://github.com/frzyc/genshin-optimizer/pull/2597 */}
+                            <LineBreak />
                           </label>
                         </Grid>
                         {shouldShowDevComponents && debugImgs && (
@@ -718,7 +722,6 @@ export function ArtifactEditor({
                 </CardThemed>
               )}
             </Grid>
-
             {/* Right column */}
             <Grid item xs={1} display="flex" flexDirection="column" gap={1}>
               {/* substat selections */}