Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #85 #90

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Fixes #85 #90

merged 3 commits into from
Apr 7, 2023

Conversation

frondeus
Copy link
Owner

@frondeus frondeus commented Apr 7, 2023 •
edited
Loading

Context

Module prevented Saving Changes in the Grid Configuration Tool. This is a fix.

What has been changed and why

The way how we store information about the syrinControl context in the scene.
By hiding it behind the closure, we no longer hit the infinite loop in the Foundry's flattenObject utils function.

Resolves

Fixes #85

Blocked by

Thigs needed to close this PR:

  • Tested manually
  • Wrote e2e test - no need
  • Wrote unit tests
  • Wrote documentation - no need

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Coverage Report:

Total:   14 lines
Missing: 0 lines
Coverage: 100%
Detailed Coverage Report 
src/sounds/ambient-sound.ts (100%)
src/sounds/playlist-sound.ts (100%)
src/sounds/playlist.ts (100%)

Repository owner deleted a comment from github-actions bot Apr 7, 2023
@frondeus frondeus merged commit 21c713e into next Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module Prevents Saving Changes in the Grid Configuration Tool
1 participant
@frondeus