-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally emit SV lengths #504
Optionally emit SV lengths #504
Conversation
5744dd4
to
20d57bb
Compare
I'd love to know what needs to be done to get some traction on this PR. It doesn't change the default behaviour, but it allows users to better understand the distribution of svlengths that the call have and thus perform better clustering and other downstream analyses. Please do consider these changes and let me know if there's anything I can do to make it easier for the maintainers. |
Thanks @hermannromanek could you take a look? |
97063b0
to
5744dd4
Compare
bump version
5744dd4
to
985bd45
Compare
Hi, I know it's not easy to find time to maintain a OSS repo. If there's anything I can do to make it easier to review my PR, Please let me know! |
Dear @yfarjoun |
Thanks for the explanation @fritzsedlazeck, that makes total sense! I will not mis-take the silence for lack of response anymore 😄 |
Thanks!! 🥳 |
Preparing release 2.5 right now :) |
closes #503
This PR adds a commandline argument that emits the lengths of the SVs found on the reads into the VCF record that contains the resulting SV. The argument is suppressed (not showing in the "help") and is prefixed with
dev-
to indicate that it's a development/debugging option.The only change to the output is the (currently non-optional) addition of the
SVLENGTHS
header line in the VCF. However, I'm happy to make this also optional. otherwise, the algorithm and output are unchanged unless--dev-emit-sv-lengths
is provided on the command-line.