1.1.2 - Working around this stacktrace.js bug for ie 10: stacktracejs…

…/stacktrace.js#80
fresheneesz · May 5, 2014 · 2ab31a3 · 2ab31a3
1 parent 9364c9c
commit 2ab31a3
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -88,6 +88,7 @@ How to submit pull requests:
 Change Log
 =========
 
+* 1.1.2 - Working around this stacktrace.js bug for ie 10: https://github.com/stacktracejs/stacktrace.js/issues/80
 * 1.1.1 - outputting line and column numbers as Numbers instead of as Strings.
 * 1.0.9 - fixing bug where the wrong stacktrace would be returned when one was passed in
 * 1.0.6 - exposing stacktrace.js's sourceCache so it can be consolidated with source caches from other modules

diff --git a/generatedBuild/stackinfo.umd.js b/generatedBuild/stackinfo.umd.js
@@ -523,6 +523,8 @@ module.exports = function(ex) {
 
     var options = undefined
     if(ex !== undefined) {
+        if(mode === 'ie' && ex.number === undefined)
+            ex.number = 1    // work around for this: https://github.com/stacktracejs/stacktrace.js/issues/80
         options = {e:ex, guess: true}
     }
     var trace = printStackTrace(options)

diff --git a/package.json b/package.json
@@ -1,5 +1,5 @@
 {"name":"stackinfo",
- "version":"1.1.1",
+ "version":"1.1.2",
  "main":"stackinfo.js",
  "description": "Gets an object containing normalized stacktrace information across browsers.",
  "keywords": ["error", "stack", "trace", "javascript", "stacktrace", "exception", "crash"],

diff --git a/stackinfo.js b/stackinfo.js
@@ -8,6 +8,8 @@ module.exports = function(ex) {
 
     var options = undefined
     if(ex !== undefined) {
+        if(mode === 'ie' && ex.number === undefined)
+            ex.number = 1    // work around for this: https://github.com/stacktracejs/stacktrace.js/issues/80
         options = {e:ex, guess: true}
     }
     var trace = printStackTrace(options)

diff --git a/test/testStackinfo.html b/test/testStackinfo.html
@@ -76,7 +76,7 @@
         testTraceline("ProtoObjectFactory.<anonymous> (http://localhost:8001/git/frontend/test/allTestsFE.bundle.js:1459:20)")
         testTraceline("(?)()@http://localhost:8001/git/frontend/test/allTestsFE.bundle.js:79:15")
         testTraceline("Object.module.exports.test.TabBar.buttons.callback [as click] (http://localhost:8001/git/frontend/test/allTestsFE.bundle.js:1546:9)")
-    } else if('firefox') {
+    } else if(stackinfo.mode === 'firefox') {
         testTraceline("(?)()@http://localhost:8100/test.web.bundle.js:75")
     }