Upgrade to repo-config v0.5.2 #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:tooling
llucax
added
type:tech-debt
llucax
force-pushed
the
repo-config-0.5
branch
2 times, most recently
from
3d58e9e to
c2b73b2
Compare
llucax
force-pushed
the
repo-config-0.5
branch
from
c2b73b2 to
34419e7
Compare
|
Not sure what's going on with the tests, locally it passes and if I remove the |
llucax
force-pushed
the
repo-config-0.5
branch
from
4422d91 to
5d32de0
Compare
llucax
force-pushed
the
repo-config-0.5
branch
2 times, most recently
from
7814900 to
f12b14a
Compare
|
test is failing |
We always want to use the template provided extensions, keeping our own list only makes it more likely to have errors when upgrading. Also `_cookiecutter` is just noise, not very useful to keep. Signed-off-by: Leandro Lucarella <[email protected]>
The key needs to be there, but the contents is only to show on the first generation, so we don't need to save it in the replay file. Signed-off-by: Leandro Lucarella <[email protected]>
This is just to be nice to editors, that usually like having a `\n` at the end of text files. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
This is to have a common basic configuration that should work with most editors/IDEs. Signed-off-by: Leandro Lucarella <[email protected]>
Now repo-config ships support to easily enable the collection and linting of code examples in docstrings, so we use that instead. Also make sure that we label the `conftest.py` file properly and we exclude it from the source distribution. Signed-off-by: Leandro Lucarella <[email protected]>
This is not really used in this project, but it is included as part of the repo-config ci template, as it doesn't hurt either. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
This is to match the name used by the repo-config template. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
repo-config-0.5
branch
from
f12b14a to
d8d04e7
Compare
github-actions
bot
added
the
part:microgrid
llucax
force-pushed
the
repo-config-0.5
branch
from
d8d04e7 to
c1f5801
Compare
github-actions
bot
removed
the
part:microgrid
This option avoids using a cache. It is slower but prevents some issues with `mypy` giving different results on different runs (typically complaining about some `type: ignore[issue]` not being used but when removing it complaining about an `issue` again. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
repo-config-0.5
branch
from
c1f5801 to
9022629
Compare
|
OK, after a long investigation it seems like the problem with This failed in the CI but worked locally because it seems like the first uncached run is the one failing, but if you run Using the |
Marenz
approved these changes
Aug 29, 2023
matthias-wende-frequenz
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes here are derived from regenerating files using the templates in repo-config v0.5.2.