-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Token Address Linking #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- I just left a couple of naming questions (that you may have thought about already). I am still working through how this repo relates to the (forthcoming) DSNP schemas repo, but this all makes sense for walletAddresses.
Recommend we reference an issue with this PR, that describes the problem being solved & other points, such as why we can't simply use 'addPublicKeyToMsa' (presumably because they're not supported key types, ie sr15519). Could also enhance the "Goal" in the README with the same information. |
@JoeCap08055 Good points.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Not trying to be picky, but I wonder if there's a better term than "payment address" that would be more clear that these are NOT (necessarily) FRQCY-holding wallets for paying transaction fees, but are simply for informational purposes |
@JoeCap08055 I am 100% open to options. "Token Addresses" didn't feel right, but perhaps? Some additional meh ideas:
|
@wilwade I'm similarly stumped as to a good name; here are some ChatGPT-generated options, maybe one will provide some inspiration:
|
Replaced by #5