Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking operation #702

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Fix blocking operation #702

merged 2 commits into from
Jul 7, 2024

Conversation

joostlek
Copy link
Contributor

@joostlek joostlek commented Jul 7, 2024

Fix blocking operation

src/tailscale/tailscale.py Outdated Show resolved Hide resolved
@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Jul 7, 2024
Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (cb07003) to head (76be2be).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   90.35%   90.17%   -0.18%     
==========================================
  Files           4        4              
  Lines         114      112       -2     
  Branches       15       15              
==========================================
- Hits          103      101       -2     
  Misses         10       10              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit 7960634 into frenck:main Jul 7, 2024
12 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants