add authenticated flag to ldap configuration #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freman
reviewed
Mar 11, 2020
freman
reviewed
Mar 11, 2020
README.md
Outdated
| @@ -239,6 +239,7 @@ Parameters for this backend: | |||
| | filter | Filter the users, eg "(&(memberOf=CN=group,OU=Users,OU=Company,DC=example,DC=com)(objectClass=user)(sAMAccountName=%s))" | | |||
| | principal_suffix | suffix to append to usernames (eg: @example.com) | | |||
| | pool_size | size of the connection pool, default is 10 | | |||
| | authenticated | true to force password be filled even server allow UNAUTHENTICATED login | | |||
There was a problem hiding this comment.
Maybe the this should be unauthenticated instead of authenticated as it's confusing
There was a problem hiding this comment.
Currently the plugin already allow unauthenticated login. I put the parameter to change this behavior enforcing authenticated policy.
If I invert this logic, turn parameter on will keep current behavior, turn parameter off will change the behavior.
I don't know if inform parameter off to enable function is clear but if you think it is better I can change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When server is using LDAP authentication and you type a valid user and keep password empty access is granted. It is because LDAP simple authentication allow one method called UNAUTHENTICATED described here https://tools.ietf.org/html/rfc4513#section-5.1.2 .
Normally login interfaces require non empty password but HTTP basic auth does not. The PR add a flag to force non empty password even if LDAP server allow unauthenticated login.
If it is false or not informed authentication behavior does not change.